Problem/Motivation

Part of #3467488: [PP-x] Deprecate support for per-file weight in libraries API.

system/base defines its CSS files under 'component' then gives them a negative weight. Instead of this we can put them in 'base' which comes before component anyway.

The stuff left in system/base really isn't for components anyway, they're generic 'utility' classes. Also unlikely anyone would override them purely via CSS overrides, much more likely to swap the files out.

Steps to reproduce

Proposed resolution

Move them from component to base and add a moved_files entry for bc.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 3619507-nr-bot_8zi82_91.txt98 bytesneeds-review-queue-bot

Issue fork drupal-3619507

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !16879

catch’s picture

catch
he/him
Primary language English
commented
Parent issue: » #3467488: [PP-x] Deprecate support for per-file weight in libraries API
Related issues: -#3467488: [PP-x] Deprecate support for per-file weight in libraries API
dcam’s picture

dcam commented
Status: Needs review » Needs work

It looked like several of the test failures are related to the changes, so I re-ran them on my local environment just to be sure. And they are related.

catch’s picture

catch
he/him
Primary language English
commented

Ahh at least one of these is a test for overriding the library where the file has moved, which is a good reminder that we need moved_files

Adding that to start with, which should turn errors into deprecation messages, then will update the tests to match the new library definitions.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes

One less stylesheet file in standard performance test is good to have.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Green MR now, also updated the issue summary a bit.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +frontend performance
catch’s picture

catch
he/him
Primary language English
commented

I think maintenance can stay in theme - actual theme files always come after module files, and afaik it's not possible for other modules to add styling to maintenance pages, this one gets hard-coded by preprocessMaintenancePage(). So moved it back there.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

In that case, I have no further feedback.

catch’s picture

catch
he/him
Primary language English
commented

Wondered why this exists at all, so opened #3623221: Deprecate system.maintenance library and ensure default admin has correct styling

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3619507-nr-bot_8zi82_91.txt98 bytes

The Needs Review Queue Bot tested this issue. The merge request has merge conflicts and cannot be merged. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.