Problem/Motivation

The phpstan job is red, 85 errors. Mostly static-analysis stuff - DI patterns it doesn't like, a few missing optional-dependency classes and some deprecations - plus one actual bug, a wrong AccessDeniedHttpException namespace.
https://git.drupalcode.org/project/external_entities/-/jobs/11782392

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork external_entities-3619316

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

velmir_taky created an issue. See original summary.

jerech made their first commit to this issue’s fork.

jerech opened merge request !149

jerech’s picture

jerech commented
Status: Active » Needs review
jerech’s picture

jerech commented

https://git.drupalcode.org/issue/external_entities-3619316/-/jobs/11816693

velmir_taky’s picture

velmir_taky commented
Status: Needs review » Needs work

Thanks @jerech, good job.
You need to check everything thoroughly, the test failed...

jerech’s picture

jerech commented
Status: Needs work » Needs review
velmir_taky’s picture

velmir_taky commented

I'll be back from vacation and will take a look at everything right away. Thank you very much.

velmir_taky’s picture

velmir_taky commented
Status: Needs review » Reviewed & tested by the community

next major is allow_failure and only trips on native return type deprecations. The one that was ours (RenderedExternalEntity::create()) is fixed; the rest come from core's EntityPublishedTrait/EntityOwnerTrait (not typed yet, #3335025: EntityOwnerTrait::getOwner() should return anonymous users not nulls) and token/pathauto. Nothing to do here until those get return types.

velmir_taky opened merge request !151

  • velmir_taky committed aeed7857 on 3.1.x 
    Issue #3619316: Fix PHPStan static analysis errors, remove direct entity...
velmir_taky’s picture

velmir_taky commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.