Problem/Motivation

I found some flaws in and related to `Drupal\Core\Hook\OrderOperation\OrderOperation`:
- In ModuleHandler, a property with packed order operations has `@param` instead of `@var`.
- The doc type of that property is wrong.
- A missing space after "match".
- In OrderOperation::unpack() we can avoid a string variable containing a class name.
- We can improve doc types for phpstan.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3618622

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

donquixote created an issue. See original summary.

charlliequadros made their first commit to this issue’s fork.

charlliequadros opened merge request !16811

charlliequadros’s picture

charlliequadros commented

Hi @donquixote

I’ve made the changes.
Could you please check if everything looks correct?
If you need anything, please let me know.

charlliequadros’s picture

charlliequadros commented
Status: Active » Needs review
donquixote’s picture

donquixote commented

Hello @charlliequadros,
I already had the commits for this in my local env, but did not take the time to push it.
My code is almost identical except for one point, going to comment.

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

Looks great, I actually forgot to comment, the return was the one thing that stuck out, I like the suggestion from @donquixote that was applied.

It removes a local variable too.