Problem/Motivation

In #3580841: Callers don't account the scenario in which JobItem::acceptTranslation() fails softly we've changed the signature of JobItemInterface::acceptTranslation() but this is wrong because it's a backwards compatibility break for modules that are already implementing JobItemInterface

Steps to reproduce

Proposed resolution

Instead, log the message directly from within the method.

Remaining tasks

None.

User interface changes

None.

API changes

Revert the JobItemInterface::acceptTranslation() signature

Data model changes

None.

Issue fork tmgmt-3618458

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Parent issue: » #3580841: Callers don't account the scenario in which JobItem::acceptTranslation() fails softly

claudiu.cristea opened merge request !181

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: claudiu.cristea » Unassigned
andras_szilagyi’s picture

andras_szilagyi commented
Status: Needs review » Reviewed & tested by the community

Looks good

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

Just try to extend JobItem::acceptTranslation() as

public function acceptTranslation() {
 ...
}

You'll get the error: "Declaration must be compatible with JobItem->acceptTranslation([&rejection_reason: null|string = NULL]) "

  • claudiu.cristea committed 39509b39 on 8.x-1.x 
    fix: #3618458 Backwards compatibility break introduced in #3580841

By:...
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.