Problem/Motivation

In Drupal 11.4, phpstan is saying,

[path]/feeds/src/Event/EventDispatcherTrait.php (in context of class Drupal\feeds\FeedHandlerBase) 27 Drupal\Core\DependencyInjection\DependencySerializationTrait does not support private properties.

Proposed resolution

Not sure yet, but I'm assigning this to myself to investigate.

Issue fork feeds-3615089

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !257

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Thanks for your contribution! The test failures look unrelated, so I scheduled the merge.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Fixed » Needs review

Apparently, tests must be fixed first before this can be merged.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Meanwhile I fixed the tests in #3615467: Fix tests and then I could merge this!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.