Problem/Motivation

Using the dev version of this module, phpstan complains about various class methods "missing the CacheableMetadata parameter added in Drupal 11.3. Update the signature to: getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity, ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL). "

Proposed resolution

Update the signature as advised.

Remaining tasks

Make an MR. I'm assigning this to myself since I intend to work on it right away.

Issue fork feeds-3615083

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !256

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Thanks for your contribution! The test failures look unrelated, so I scheduled the merge.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Fixed » Reviewed & tested by the community

Apparently, tests must be fixed first before this can be merged.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Meanwhile I fixed the tests in #3615467: Fix tests and then I could merge this!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.