Problem/Motivation

Start moving tests to Olivero so the theme can be deprecated.

Steps to reproduce

git grep -lwi "'olivero'" | grep -v core/themes/olivero/ | grep -v core/assets | grep -v phpstan-baseline | grep -v MAINTAINERS | grep -i test

Proposed resolution

This is for tests that are a simple change of directory.
With the changes in the MR there are still 51 tests that use the word 'olivero'. They will be done elsewhere
Includes moving TestSiteOliveroInstallTestScript.php to Olivero which then required changing the setup path in the nightwatch tests.

Remaining tasks

Review
Commit

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#23 3614949-nr-bot_p5_m_jvq.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3614949

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16554

quietone’s picture

quietone commented
Status: Active » Needs review
quietone’s picture

quietone commented
Title: Move nightwatch tests to Olivero » Move tests to Olivero
Issue summary: View changes
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Could the summary be cleaned up slightly? The title says tests so I assume all tests. The problem mentions tests in general too, but proposed solution mentions just nightwatch just trying to determine scope.

But looking in the nightwatch folder the nightwatch.config.js uses Olivero as it's defaultTheme, if this is ticket is just nightwatch can we update that value to something else?

quietone’s picture

quietone commented
Title: Move tests to Olivero » Move tests to Olivero, part 1
Issue summary: View changes
Status: Needs work » Needs review

This is not just for nightwatch tests but it is only for tests. Files like nightwatch.config.js are excluded.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Not 100% why the config is excluded. But it’s a good chunk so it’s something

  • catch committed 43a0bd4c on 11.x 
    task: #3614949 Move tests to Olivero, part 1

By: quietone
By:...

  • catch committed 290905eb on main 
    task: #3614949 Move tests to Olivero, part 1

By: quietone
By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Very straightforward. Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented
Status: Fixed » Needs work

This is causing test failures on 11.x, on core/tests/Drupal/KernelTests/Core/Test/PhpUnitApiGetTestClassesTest.php with messages like

RuntimeException: The autoloader expected class "Drupal\Tests\olivero\FunctionalJavascript\OliveroMessagesTest" to be defined in file "/var/www/html/core/themes/olivero/tests/src/FunctionalJavascript/OliveroMessagesTest.php". The file was found but the class was not in it, the class name or namespace probably has a typo.

  • catch committed 188a31f7 on 11.x 
    Revert "task: #3614949 Move tests to Olivero, part 1"

This reverts...

  • catch committed 1d278e2f on main 
    Revert "task: #3614949 Move tests to Olivero, part 1"

This reverts...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » main

Pushed a revert. This means the namespace is wrong in main too so reverted from there as well.

quietone reopened merge request !16554

quietone opened merge request !16711

quietone’s picture

quietone commented
Status: Needs work » Needs review

The name spaces are fixed and there is an MR for 11.x. All tests are passing.

edit: correct typos

quietone’s picture

quietone commented
Issue summary: View changes

I added to this moving TestSiteOliveroInstallTestScript.php to Olivero which then required changing the setup path in the nightwatch tests.

quietone’s picture

quietone commented

The 11.x tests failures should be fixed by #2672340: user_user_role_insert should not exist

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Lets try this again...

  • catch committed b4fabdb6 on main 
    task: #3614949 Move tests to Olivero, part 1

By: quietone
By:...
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3614949-nr-bot_p5_m_jvq.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Needs work » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 59f186f9 on 11.x 
    task: #3614949 Move tests to Olivero, part 1

By: quietone
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.