Problem/Motivation
The ESLint job in the current 8.x-1.x baseline fails as an allowed failure, so the pipeline reports passed with warnings.
Exact CI findings
Pipeline 911674, job 11344552 reports 8 errors in comment_notify.js: Prettier quote/formatting errors at 2:3, 7:15, 8:70, 9:13, and 11:18; unnecessary strict mode at 2:3; non-shorthand method syntax at 5:5; and prohibited jQuery .bind() at 6:7. Seven are auto-fixable; the event binding requires a focused code change.
Proposed resolution
Format the behavior to current Drupal JavaScript standards and replace deprecated jQuery event binding with .on(), without changing behavior.
Testing instructions
- Run Drupal core ESLint/Prettier rules against
comment_notify.js. - Exercise the notification checkbox behavior.
- Run the complete Comment Notify test suite.
- Confirm the ESLint CI job passes.
Relevant CI
AI use disclosure
AI-Generated: Yes. OpenAI Codex was used to inspect the current CI output, draft this issue, and will assist with implementation and verification. All changes and test results will be reviewed by a human before merge.
Issue fork comment_notify-3614938
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
gnugetValidation complete.
Merge request: https://git.drupalcode.org/project/comment_notify/-/merge_requests/26
Pipeline: https://git.drupalcode.org/project/comment_notify/-/pipelines/911699
Targeted ESLint job: https://git.drupalcode.org/project/comment_notify/-/jobs/11344778 — passed.
The complete Comment Notify test directory was also run locally in DDEV and completed successfully. No merge was performed.
AI-Generated: Yes. OpenAI Codex assisted with implementation, test execution, CI inspection, and drafting this validation update. The change remains subject to human review before merge.
Comment #5
gnuget