Problem/Motivation

The TMGM messages are flooded with no reason by the "Source was updated, changes were ignored as job item is still active." message

Why it's wrong?

The source was not updated. A translation was accepted. ContinuousManager::addItem() has no guard to check whether there are translation changes, it only checks "entity saved + open item exists" and logs regardless.

Proposed resolution

Maybe we should add a new $entity->getUntranslated()->hasTranslationChanges() guard in ContinuousManager::addItem() and only record the message when really makes sense

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork tmgmt-3611439

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Title: Message flood "Source was updated, changes were ignored as job item is still active" » Messages flooded by "Source was updated, changes were ignored as job item is still active"
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes
alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented
Assigned: Unassigned » alorenc

alorenc opened merge request !174

alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented
Assigned: alorenc » Unassigned
Status: Active » Needs review
alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented

One option is to remove the message entirely, as it is purely diagnostic. We do not log anything when shouldCreateItem() evaluates to FALSE, or when a customization changes that outcome via ShouldCreateJobEvent.
Logging only the "active job item" case is inconsistent with the rest of addItem(), where similar outcomes are handled silently. The simplest solution may be to remove this log message altogether, so the code no longer treats this single condition differently from the others.

alorenc opened merge request !175

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Thank you for the 2nd MR, I will close the 1st. Some nits in the 2nd MR and I think is worth it top add very simple kernel test.

claudiu.cristea closed merge request !174

yaqbick made their first commit to this issue’s fork.

yaqbick’s picture

yaqbick commented
Status: Needs work » Reviewed & tested by the community
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Needs work

The issue was tagged with "Needs tests". See #11

alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented

Added a test, but the change itself is trivial. Adding additional tests only creates unnecessary noise.

yaqbick’s picture

yaqbick commented
Status: Needs work » Reviewed & tested by the community

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Fixed

Merged. Thank you for contribution

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.