Problem/Motivation

When a task is moved from one column/swimlane to another, there are two notification emails sent.
My guess is that it sends one for the removal of the first column id, and then another for the addition of the new column id. It is hard to detect this because neither email shows the column name.

Steps to reproduce

Proposed resolution

  • Look to see if there is a way to condense this to one event instead of two
  • Add the column name to the email.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork burndown-3610527

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

swirt created an issue. See original summary.

swirt’s picture

swirt
he/him
Primary language English
commented

This is interesting. Moving a task from one column to another, definitely does generate two emails, but only one is related to the column change. The other is from an "edit" just like the column change though it shows no diff change... which leads me to believe the change is in one of the values not tracked by the diff.... maybe log, 'backlog_sort' or 'board_sort? I will have to step through it to see.

swirt’s picture

swirt
he/him
Primary language English
commented
Assigned: Unassigned » swirt
jeremylichtman’s picture

jeremylichtman commented

I wonder if the ignore field list from the other issue will have fixed this.

swirt’s picture

swirt
he/him
Primary language English
commented

Confirmed, I commented out the ignore field check and it is the change to the sort order that triggers the second email. Apparently it is handled by two separate api calls so one move shows up as two different edits because they are different edits.

I can't think of a way for one to know about the other and prevent the double send :(

Since the diff was never showing changed to board sort, what do you think about checking to see if there is no reported changes in the diff, we skip sending an edit email? That would solve the problem of both the double send, and an edit notice with no visible changes.

swirt opened merge request !39

swirt’s picture

swirt
he/him
Primary language English
commented
Status: Active » Needs review

This is ready for review and concludes my planned work on email related stuff. So a release can follow.

jeremylichtman’s picture

jeremylichtman commented

Merged. Preparing a release.

jeremylichtman’s picture

jeremylichtman commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jeremylichtman’s picture

jeremylichtman commented
Status: Fixed » Closed (fixed)

Fixed on 1.0.64.