Problem/Motivation

Varbase Core and its submodules (Admin, Internationalization, Page, Security, Tour, Webform, Development, Update Helper) grant role permissions via Vardot\Installer\ModuleInstallerFactory::addPermissions() (scanning config/permissions), which silently skips a missing role instead of validating. Following the Drupal core Recipe approach already used on Varbase API and several other Varbase 9.2.x modules makes this declarative and validated.

Steps to reproduce

Proposed resolution

Move the role permission grants into a recipes/default/recipe.yml for the main module and each submodule that grants real permissions (config actions only, module installation stays as-is), drop config/permissions/, and call the recipe at the end of each module’s hook_install() instead of addPermissions(). Development and Update Helper have no real permissions to grant, so their config/permissions/ and the addPermissions() call are simply removed, with the now-unused ModuleInstallerFactory import dropped from Update Helper.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Reviewed by a human
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release varbase-9.2.0, varbase_core-9.2.0

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 45acf208 on 9.2.x
    task: #3608646 Switch to a Default Varbase Core recipe and drop the use...
rajab natshah’s picture

Issue tags: +varbase_core-9.2.0
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
Issue tags: +varbase-9.2.0
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: rajab natshah » josebc
Status: Active » Needs review
rajab natshah’s picture

Assigned: josebc » mohammed j. razem
Issue summary: View changes

✅ Released varbase_core-9.2.0

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.2.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.