Problem/Motivation
Varbase Core and its submodules (Admin, Internationalization, Page, Security, Tour, Webform, Development, Update Helper) grant role permissions via Vardot\Installer\ModuleInstallerFactory::addPermissions() (scanning config/permissions), which silently skips a missing role instead of validating. Following the Drupal core Recipe approach already used on Varbase API and several other Varbase 9.2.x modules makes this declarative and validated.
Steps to reproduce
Proposed resolution
Move the role permission grants into a recipes/default/recipe.yml for the main module and each submodule that grants real permissions (config actions only, module installation stays as-is), drop config/permissions/, and call the recipe at the end of each module’s hook_install() instead of addPermissions(). Development and Update Helper have no real permissions to grant, so their config/permissions/ and the addPermissions() call are simply removed, with the now-unused ModuleInstallerFactory import dropped from Update Helper.
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ✅ Reviewed by a human
- ✅ Code review by maintainers
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes
- ✅ Release varbase-9.2.0, varbase_core-9.2.0
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Released in varbase_core-9.2.0
Issue fork varbase_core-3608646
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
rajab natshahComment #5
rajab natshahComment #6
rajab natshahComment #7
rajab natshahComment #8
rajab natshahComment #9
rajab natshahComment #10
rajab natshah✅ Released varbase_core-9.2.0
Comment #11
rajab natshahComment #12
rajab natshahComment #14
rajab natshah✅ Released varbase-9.2.0