Problem/Motivation

Varbase Blog grants role permissions via Vardot\Installer\ModuleInstallerFactory::addPermissions() (scanning config/permissions), which silently skips a missing role or an invalid permission instead of validating. Following the Drupal core Recipe approach already used on Varbase API and Varbase Media makes this declarative and validated.

Steps to reproduce

Proposed resolution

Move the role permission grants into recipes/default/recipe.yml (config actions only, module installation stays as-is), drop config/permissions/, and call the recipe at the end of varbase_blog_install() instead of addPermissions().

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Reviewed by a human
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release varbase-9.2.0, varbase_blog-9.2.0

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • task: #3608632 Switch to a Default Varbase Blog recipe and drop the use of the Module Installer Factory class for permissions
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed dc30168a on 9.2.x
    task: #3608632 Switch to a Default Varbase Blog recipe and drop the use...
rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
Status: Active » Fixed
Issue tags: +varbase-9.2.0, +varbase_blog-9.2.0

✅ Released varbase_blog-9.2.0

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.2.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.