Declaration of TrashNodeSearch::indexStatus is not compatible with 11.4.x's SearchNode::indexStatus

Problem/Motivation

Drupal 11.4.0 became available on 2026-07-01.

In Drupal 11.4.0, the node search functionality was moved to a sub-module (see change record 3590298: Node search plugin node_search moved to sub-module Search Node in Search). As part of this, \Drupal\node\Plugin\Search\NodeSearch moved to \Drupal\search_node\Plugin\Search\NodeSearch. Also, the signature of the indexStatus() function changed...

-public function indexStatus()
+public function indexStatus(): array

In trash-3.0.28, trash-3.x-dev, and trash-3.1.x-dev, there is a stub function \Drupal\trash\Plugin\Search\TrashNodeSearch::indexStatus(). Its indexStatus() function override has the signature...

public function indexStatus(): mixed

... and I guess PHP 8.3.30 (i.e.: what my local machine is testing on) doesn't consider mixed and array to be compatible.

Steps to reproduce

1. Set up a site using Drupal core version 11.3.13
2. Install trash-3.0.28, trash-3.x-dev, or trash-3.1.x-dev
3. Upgrade the site to drupal-11.4.0
4. Run database updates
   Expected behavior: the site upgrades with no errors
   Actual behavior: during system_update_11401 you see the following error message:

   > PHP Fatal error:  Declaration of Drupal\trash\Plugin\Search\TrashNodeSearch::indexStatus(): mixed must be compatible with Drupal\search_node\Plugin\Search\SearchNode::indexStatus(): array in /var/www/html/web/modules/contrib/trash/src/Plugin/Search/TrashNodeSearch.php on line 47
   >  [error]  RuntimeException: Recursive router rebuild detected. in Drupal\Core\Routing\RouteBuilder->rebuild() (line 114 of /var/www/html/web/core/lib/Drupal/Core/Routing/RouteBuilder.php) #0 /var/www/html/web/core/lib/Drupal/Core/Routing/RouteBuilder.php(160): Drupal\Core\Routing\RouteBuilder->rebuild()
   > #1 /var/www/html/web/core/lib/Drupal/Core/Routing/RouteBuilder.php(172): Drupal\Core\Routing\RouteBuilder->rebuildIfNeeded()
   > #2 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(729): Drupal\Core\Routing\RouteBuilder->destruct()
   > #3 /var/www/html/vendor/drush/drush/src/Boot/DrupalBoot8.php(320): Drupal\Core\DrupalKernel->terminate()
   > #4 [internal function]: Drush\Boot\DrupalBoot8->terminate()
   > #5 {main}. 
   > RuntimeException: Recursive router rebuild detected. in /var/www/html/web/core/lib/Drupal/Core/Routing/RouteBuilder.php on line 114 #0 /var/www/html/web/core/lib/Drupal/Core/Routing/RouteBuilder.php(160): Drupal\Core\Routing\RouteBuilder->rebuild()
   > #1 /var/www/html/web/core/lib/Drupal/Core/Routing/RouteBuilder.php(172): Drupal\Core\Routing\RouteBuilder->rebuildIfNeeded()
   > #2 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(729): Drupal\Core\Routing\RouteBuilder->destruct()
   > #3 /var/www/html/vendor/drush/drush/src/Boot/DrupalBoot8.php(320): Drupal\Core\DrupalKernel->terminate()
   > #4 [internal function]: Drush\Boot\DrupalBoot8->terminate()
   > #5 {main}
   
   In ProcessBase.php line 171:
   
   Unable to decode output into JSON: Syntax error
   
   Fatal error: Declaration of Drupal\trash\Plugin\Search\TrashNodeSearch::indexStatus(): mixed must be compatible with Drupal\search_node\Plugin\Search\SearchNode::indexStatus(): array in /var/www/html/web/modules/contrib/trash/src/Plugin/Search/TrashNodeSearch.php on line 47
   RuntimeException: Recursive router rebuild detected. in Drupal\Core\Routing\RouteBuilder->rebuild() (line 114 of /var/www/html/web/core/lib/Drupal/Core/Routing/RouteBuilder.php).
   

Proposed resolution

Lets try changing the signature to match 11.4.0's public function indexStatus(): array. It seems like a return type is undeclared in 10.3.x, 10.4.x, 10.5.x, 10.6.x, 11.0.x, 11.1.x, 11.2.x, and 11.3.x.

Remaining tasks

1. Determine if a return type of :array is compatible with core ^10.3 | ^11 - @mparker17 thinks it should be
2. Create a merge request - merge request !135 created by @mparker17 in #3 for 3.1.x branch
3. Community review - done by @mark_fullmer in #7
4. Maintainer review - done by @amateescu before #8
5. Commit to 3.1.x - done by @amateescu in #8
6. Commit to 3.x - done by @amateescu in #9
7. Release - released in trash-3.0.29

User interface changes

None.

API changes

The signature of Drupal\trash\Plugin\Search\TrashNodeSearch::indexStatus(): mixed changes to Drupal\trash\Plugin\Search\TrashNodeSearch::indexStatus(): array.

Data model changes

None.