Problem/Motivation

Upgrade from drupal 11.3.13 to 11.4.0 introduces new error.

Steps to reproduce

Do the upgrade - site with protected pages enabled breaks for all pages.

Proposed resolution

Google has some recommendations, but it would be better coming from the developers.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork protected_pages-3607774

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

william haller created an issue. See original summary.

karlshea made their first commit to this issue’s fork.

karlshea opened merge request !47

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Active » Needs review

ProtectedPagesSubscriber was using concrete classes in its constructor instead of interfaces.

kurttrowbridge’s picture

kurttrowbridge
he/him
commented
Status: Needs review » Reviewed & tested by the community

I ran into this today upon upgrading to 11.4.0 as well, and the MR fixed it. Thanks!

silke’s picture

silke commented

Thank you, @karlshea. Same issue for me with 11.4.1, your MR #3 fixed it.

vasike’s picture

vasike
Location Ramnicu Valcea
commented

I also confirm both the issue with 11.4.x and MR fix.

seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
commented

Another +1 from me. Thanks @karlshea!

carolpettirossi’s picture

carolpettirossi commented

+1, hopefully we can get this merged and release ASAP.

  • oksana-c committed d2bbd9b6 on 8.x-1.x authored by karlshea 
    fix: #3607774 Use interfaces instead of concrete classes

By: william...
oksana-c’s picture

oksana-c commented
Status: Reviewed & tested by the community » Fixed

Merged. Thank you all!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @oksana-c could you tag a new stable release please?

oksana-c’s picture

oksana-c commented
Status: Fixed » Closed (fixed)

Done.