Fatal error: Type of Drupal\file_entity\Plugin\Field\FieldFormatter\FileImageResponsiveFormatter::$currentUser must be Drupal\Core\Session\AccountInterface

Hi @n.dhuygelaere

I was able to reproduce this after updating from Drupal 11.3 to Drupal 11.4.0

The issue happens because FileImageResponsiveFormatter extends core’s ImageFormatter, but it redeclares inherited properties without the same types now used by core in Drupal 11.4.

I created an MR to fix the compatibility issue

After applying the change, the fatal error is resolved.

have you tried 8.x-2.5-rc2 ???

I just tagged 8.x-2.5

please test against 11.4

The current patch created for the dev branch do not apply cleanly to the stable 8.x-2.5 (2.5.0) release of file_entity due to line number and whitespace context differences.

Furthermore, when updating to Drupal Core 11.4.0, because the stable 2.5.0 code is missing the use statements for AccountInterface and EntityStorageInterface at the top of the file, applying the dev patch directly results in a PHP compilation error: Fatal error: Class "Drupal\file_entity\Plugin\Field\FieldFormatter\AccountInterface" not found

To fix this on Drupal 11.4.0 with the stable file_entity 2.5.0 release, I have created a patch that uses the fully qualified class names (\Drupal\Core\Session\AccountInterface and \Drupal\Core\Entity\EntityStorageInterface). This allows the patch to apply cleanly to the stable release and resolves the PHP fatal error immediately without requiring additional class imports.

I have attached the patch below: file_entity-3607726-typehint-2.5.0.patch.

#10 is good for 2.6 and 11.4.2

previously this change was causing test failures

Changes from merge request #33 apply cleanly to file_entity 2.6 and appear to work with Drupal core 11.4.4.

Can't merge this, it breaks phpunit testing, many fails.

Also confirm MR#33 working against 11.4.4 & file_entity 2.6

sure is a lot of test failures for D11.4.x

FIXED!

I had to also adjust the automated test due to an admin page in core moving around.

Thanks!

https://www.drupal.org/project/file_entity/releases/8.x-2.7

Everyone above has been creditted with the fix.

Is the following fatal error during {site}/update.php the same error that the patch above portends to repair?

PHP Fatal error:  

Type of Drupal\file_entity\Plugin\Field\FieldFormatter\FileImageResponsiveFormatter::
     $currentUser must not be defined (as in class Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter) in:

{site}/modules/file_entity/src/Plugin/Field/FieldFormatter/FileImageResponsiveFormatter.php on line 27

Had to set the composer.json file to version 2.6.0 to prevent module upgrade until these problems get repaired.

The above error also occurred for me on a 11.3.16 site. So perhaps this works with 11.4.x but breaks 11.3.x?

Thanks for the feedback, working on it.

hmm, looking to see if there's a better solution.

Ok 2.8 should do the job.

Sorry for the inconvenience and I thank you for the quick reporting.

https://www.drupal.org/project/file_entity/releases/8.x-2.8

Wow! Thank you for quickly pushing out a hot fix release.
-
Both the composer.json updating and the {site}/update.php runs were clean and in the green.
-
I then checked node bundles that use file entities and all seem good that i had time to check.
-
This hot fix release should hopefully reduce the number of problems that currently block upgrades to 11.4.x drupal core.