Problem/Motivation

As Drupal 11 evolves, we need to prepare the site_assistant module for upcoming core changes.

To leverage newer Drupal 11 APIs (specifically targeting Drupal 11.4.x and subsequent 11.x releases) without breaking compatibility for users still on older core setups, we need to introduce a new 3.0.x major version branch. This allows us to keep 2.0.x as a stable LTS branch for Drupal 10.6/11.x legacy environments.

Proposed resolution

  • Create a new 3.0.x branch from 2.0.x.
  • Update the site_assistant.info.yml to require core_version_requirement: ^11.4.
  • Keep the 2.0.x branch open for security fixes and backports, maintaining its current compatibility (Drupal 10.6.x to 11).

Remaining tasks

  • Create the 3.0.x branch and merge request updating the core_version_requirement in the 3.0.x branch.
  • Update automated testing infrastructure (GitLab CI) if necessary to test against Drupal 11.4+.

User interface changes

None.

API changes

None immediately, but the 3.0.x branch will be allowed to use APIs introduced in Drupal 11.4+.

Data model changes

None.

CommentFileSizeAuthor
#2 site_assistant.2.0.x-dev.upgrade_status.post_rector.txt8.74 KBproject update bot
#2 site_assistant.2.0.x-dev.rector.patch9.83 KBproject update bot

Issue fork site_assistant-3603104

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

project update bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new site_assistant.2.0.x-dev.rector.patch9.83 KB
new site_assistant.2.0.x-dev.upgrade_status.post_rector.txt8.74 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version 1.0.0-beta1, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-848511

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha2
  2. mglaman/phpstan-drupal: 2.0.15
  3. palantirnet/drupal-rector: 1.0.0-beta1

project update bot opened merge request !6

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Assigned: Unassigned » steffenr
Issue summary: View changes
Status: Needs review » Active

I'll have a look at the changes and improve the module further.
The current 2.x branch will be available for 10.x to <11.4.

A new 3.x branch will be created for 11.4 || 12 compatibility.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Title: Automated Drupal 12 compatibility fixes for site_assistant 2.0.x-dev » Provide version 3.0.x for Drupal 11.4 and remove deprecated code
Issue summary: View changes
Issue tags: -ProjectUpdateBotD12, -Drupal 12 compatibility
steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Version: 2.0.x-dev » 3.0.x-dev

steffenr closed merge request !6

steffenr changed the visibility of the branch 3603104-automated-drupal-12 to hidden.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented

steffenr opened merge request !9

  • steffenr committed f70f0070 on 3.0.x 
    Issue #3603104: Update PHPStan configuration and drop the baseline

  • steffenr committed 9aa2be23 on 3.0.x 
    Issue #3603104: Use explicit service alias syntax for...

  • steffenr committed 8e516721 on 3.0.x 
    Issue #3603104: Cache the active assistant lookup per request

  • steffenr committed 53dca1b0 on 3.0.x 
    Issue #3603104: Add strict typing and PHPUnit attributes across the...

  • steffenr committed 1fb4adc2 on 3.0.x 
    Issue #3603104: Remove redundant EntityCreatedInterface

  • steffenr committed 138313f9 on 3.0.x 
    Issue #3603104: Add backend API endpoint for the assistant panel

  • steffenr committed 7e12ee3c on 3.0.x 
    Issue #3603104: Add Single Directory Components and render the assistant...

  • steffenr committed 68116611 on 3.0.x 
    Issue #3603104: Replace Backbone.js with vanilla JavaScript

  • steffenr committed 40a50a09 on 3.0.x 
    Issue #3603104: Replace AutowireEntityHandlerTrait with core...

  • steffenr committed b249c6a4 on 3.0.x 
    Issue #3603104: Move hook implementations to OOP hook classes

  • steffenr committed a5d98573 on 3.0.x 
    Issue #3603104: Convert entity type definitions from annotations to...

  • steffenr committed 4d09a7d1 on 3.0.x 
    Issue #3603104: Require Drupal ^11.4 and PHP 8.3
steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.