Problem/Motivation

Drupal Commerce now has the "Manual" payment type built into core.

It allows adding a manual payment in the admin area for an order:
/admin/commerce/orders/12345/payments/add

Here it would be great, if the manual payment method type could provide a "Note" field, because manual payments often have special reasons, like for example manual corrections of failed external payments etc.

I think this would be useful for everyone.

If the manual payment is also used client-facing in the checkout, you could also allow users to enter a text, if it makes sense in certain cases.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork commerce-3593463

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Status: Active » Needs review

Done. Please review!

Unsure, whether we really need it in the legacy "ManualPaymentAddForm", but I added it in both places.

grevil opened merge request !734

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks @grevil, perfect! Just tried it and works like a charm.

It's implemented similiarly to "Payment received" in the lines before (https://git.drupalcode.org/project/commerce/-/merge_requests/734/diffs?f...) so should be perfectly fine!

The only thing I'm unsure about is, if we should call it a bit differently, e.g.

  • Payment note
  • Admin note
  • Admin payment note

?

or just admin_note or payment_note as machine name?

Marking this RTBC for the maintainers to review and decide.

This is super helpful for the described case of manual payment corrections to document them usefully.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Re-confirmed from our client that this is very helpful for them in manual payments.