Upgrading Watcher uses deprecated method

I've tested the update script and it seemed to work. Running 6.8 or 6.9?

Cool, cheers!

I cannot recreate this problem, I've attempted installs and uninstalls. Updates seem to work too. Did you try this on a clean Drupal 6.9 install?

Cool! Keep me posted!

I think the problem you refer to above is caused by a field that's never being created. I've fixed that now, will make a new release.

I got the same error as Pixelstyle when updating watcher Alpha 2 to Alpha 3 and then from Alpha 3 to Alpha 4 on a clean install of Drupal 6.9.

Here are the errors from the webserver's log file
[19-Jan-2009 12:31:59] PHP Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_drop_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/hsphere/local/home/eapprais/new.dast2dast.org/modules/watcher/watcher.install on line 52
[19-Jan-2009 12:31:59] PHP Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_add_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/hsphere/local/home/eapprais/new.dast2dast.org/modules/watcher/watcher.install on line 53

[19-Jan-2009 14:57:41] PHP Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_drop_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/hsphere/local/home/eapprais/new.dast2dast.org/modules/watcher/watcher.install on line 52
[19-Jan-2009 14:57:41] PHP Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_add_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/hsphere/local/home/eapprais/new.dast2dast.org/modules/watcher/watcher.install on line 53
[19-Jan-2009 14:57:47] PHP Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_drop_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/hsphere/local/home/eapprais/new.dast2dast.org/modules/watcher/watcher.install on line 52
[19-Jan-2009 14:57:47] PHP Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_add_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/hsphere/local/home/eapprais/new.dast2dast.org/modules/watcher/watcher.install on line 53

Now every time I use update.php, on top of the page, I have the following error noted:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_drop_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/hsphere/local/home/eapprais/new.dast2dast.org/modules/watcher/watcher.install on line 56 Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_add_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/hsphere/local/home/eapprais/new.dast2dast.org/modules/watcher/watcher.install on line 57

Also, watcher does not seem to email users watching posts. So far, I have not received a single notification on nodes update/comments for the nodes I'm watching. The site is http://www.new.dast2dast.org.

Thank you in advance

Thank you for your report regarding the db issue. I'll investigate this as soon as I can.

As for the email issue, did you try the Testing tools on the module's settings page?

Please open a new issue for the email problem! Thanks.

Thank you solipsist. I will open a new issue for the email problem and will check back here about the db issue.

This bug should be fixed by now. Fix will be included in next alpha release.