Problem/Motivation

The "max PHP version" (PHP 8.5) tests are not passing. There are many "Exception: Deprecated function: Using null as an array offset is deprecated, use an empty string instead" warnings.

Proposed resolution

Fix the "Using null" warnings and any other thing that is preventing the tests from passing.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork webform-3590360

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

liam morland opened merge request !867

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review

The merge request contains a bunch of fixes. There are still some "Using null as an array offset is deprecated" messages about ViewsViewsHooks->viewsData(). I think those were fixed in #3347842: Deprecate the trusted data concept in configuration; see #3563306: Views views_data hook is not entirely PHP 8.5 ready.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Another "Using null as an array offset" message has a fix in #3590967: [PHP 8.5] ContentTranslationManageAccessCheck passes NULL to LanguageManager::getLanguage().

  • liam morland committed c103ea6e on 6.3.x 
    fix: #3590360 Avoid NULL array key in WebformOptionsCustom::...

  • liam morland committed 9e368483 on 6.3.x 
    fix: #3590360 Avoid NULL array key WebformSubmission::isOwner()

A...

  • liam morland committed 5ade2dbf on 6.3.x 
    fix: #3590360 Avoid NULL array key in Webform::getElement()

  • liam morland committed 639f18aa on 6.3.x 
    fix: #3590360 Avoid NULL array key in WebformAdminConfigBaseForm

  • liam morland committed 265c3314 on 6.3.x 
    fix: #3590360 Do not call FormStateInterface::setErrorByName() with NULL...

  • liam morland committed 68866791 on 6.3.x 
    fix: #3590360 Ensure $key is not NULL in Webform::getPage()

  • liam morland committed 81130df7 on 6.3.x 
    fix: #3590360 Ensure $operation is not NULL in Webform::getPages()

  • liam morland committed c103ea6e on 6.x 
    fix: #3590360 Avoid NULL array key in WebformOptionsCustom::...

  • liam morland committed 9e368483 on 6.x 
    fix: #3590360 Avoid NULL array key WebformSubmission::isOwner()

A...

  • liam morland committed 5ade2dbf on 6.x 
    fix: #3590360 Avoid NULL array key in Webform::getElement()

  • liam morland committed 639f18aa on 6.x 
    fix: #3590360 Avoid NULL array key in WebformAdminConfigBaseForm

  • liam morland committed 265c3314 on 6.x 
    fix: #3590360 Do not call FormStateInterface::setErrorByName() with NULL...

  • liam morland committed 68866791 on 6.x 
    fix: #3590360 Ensure $key is not NULL in Webform::getPage()

  • liam morland committed 81130df7 on 6.x 
    fix: #3590360 Ensure $operation is not NULL in Webform::getPages()
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Active

Fixes committed; leaving open until tests pass on PHP 8.5. The rest of the fixes are likely in Drupal core; see comment #3 and #4.