Problem/Motivation

Implement OOP hooks for better OOP & DI support, instead of having all hook logic in the module file.

Proposed resolution

Convert hook implementations to OOP hooks, with backwards compatibility.
See https://www.drupal.org/node/3442349

Issue fork popup_message-3590318

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

igor mashevskyi created an issue. See original summary.

igor mashevskyi opened merge request !27

igor mashevskyi’s picture

igor mashevskyi commented
Assigned: igor mashevskyi » Unassigned
Status: Active » Needs review
akashkumar07’s picture

akashkumar07 commented
Status: Needs review » Needs work

I have reviewed the changes. Overall it looks good.
We just need to make few changes to make it perfect. Thanks!

igor mashevskyi’s picture

igor mashevskyi commented
Status: Needs work » Needs review
akashkumar07’s picture

akashkumar07 commented
Status: Needs review » Needs work

@igor-mashevskyi the changes look good. The last change please use DI for this service.

$filter_manager = \Drupal::service('plugin.manager.filter');

Thanks!

igor mashevskyi’s picture

igor mashevskyi commented
Status: Needs work » Needs review
akashkumar07’s picture

akashkumar07 commented
Status: Needs review » Reviewed & tested by the community

Verified the changes and functionality is working as expected.
Moving to RTBC.

usingsession made their first commit to this issue’s fork.

usingsession’s picture

usingsession commented
Status: Reviewed & tested by the community » Fixed

Merged into 3.x.

Before merging I added 'filter' to $modules in PopupMessageStatusControllerTest. The new help hooks service needs plugin.manager.filter, and kernel tests do not install module dependencies on their own.

Thanks @igor mashevskyi for the work and @akashkumar07 for the reviews.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • usingsession committed f10decad on 3.x 
    Issue #3590318: Match core requirement in composer.json to info.yml

By...