[1.0.x] Mosaic

Thank you for applying!

Before giving links helpful to understand how the review process works, what to expect from a review, and what to do to avoid a review takes more time than needed, I would like to thank all the reviewers for the work they do.
These applications are volunters-driven, which also means it is not possible to predict when an application will be marked fixed and the applicant will get the permission to opt projects into security advisory policy. While we aim to make an application as quick as possible, it is also important for us that more people review the project used for an application. In this way, we make sure applications do not miss some important points that should be instead reported.
Applications are not meant to be complete debugging sessions that eliminate every existing bug, though. I apologize if sometimes applications seem to go into too-detailed reviews.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

1. FILE: mosaic.libraries.yml

version: VERSION

VERSION is only used by Drupal core modules. Contributed modules should use a literal string that does not change with the Drupal core version a site is using.

2. FILE: mosaic.module and modules/mosaic_canvas_bridge/mosaic_canvas_bridge.module

A new module that aims to be compatible with latest Drupal releases is expected to implement hooks as class methods as described in Support for object oriented hook implementations using autowired services.

It is better not to create new releases during these applications, since a review could ask for a change that is not backward compatible with the existing releases. Just using a development version avoids those BC issues.

Rest seems fine to me.

Please wait for other reviewers and Project Moderator to take a look and if everything goes fine, you will get the role.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that does not follow the coding standards, contains possible security issue, or does not correctly use the Drupal API
• The single review points are not ordered, not even by importance

src/Hook/MosaicHooks.php

    $account = \Drupal::currentUser();
    if ($account->hasPermission('mosaic.administer')) {
      $attachments['#attached']['library'][] = 'mosaic/device_preview';
      $attachments['#attached']['drupalSettings']['mosaic']['devicePreview'] = TRUE;
    }

Any dependency must be injected using the dependency injection container, except in the case the dependency is used only from static methods.

Hook classes are essentially autowired service classes that do not need to be defined in the .services.yml file. As such, any dependency is defined as parameter of the class constructor.

It is also better to initialize the string translation instance calling setStringTranslation().

    foreach ($updates as $id => $info) {
      $label   = $info['label'] ?? $id;
      $version = $info['version'] ?? '?';
      $items[] = $this->t('@label (v@version)', ['@label' => $label, '@version' => $version]);
    }

Is the label a translatable string?

    return [
      'mosaic_template_updates' => [
        'title'       => $this->t('Mosaic: template updates pending review'),
        'description' => $this->t('The following global templates have been updated since their initial deployment. Layouts derived from these templates may need to be reviewed by content editors: @list', [
          '@list' => implode(', ', array_map('strval', $items)),
        ]),
        'severity'    => REQUIREMENT_WARNING,
        'value'       => $this->t('@count template(s) updated', ['@count' => count($updates)]),
      ],
    ];

As per Drupal coding standards, only a white space is required before and after the assignment operator and other operators.

LICENSE.txt

The content of the LICENSE.txt file is expected to be the same of the LICENSE.txt file used by Drupal core.

modules/mosaic_acsf/mosaic_acsf.module

Drupal core no longer requires a .module file to recognize a module. If those files do not contain code, they can be omissed.

src/Controller/AiGenerateController.php

A controller class is not supposed to be extended by classes implemented by other modules, so it is fine to use private property. It would also be better to define the class final.

    if ($has('hero', 'landing', 'homepage', 'home page', 'welcome')) {
      return array_values(array_filter([
        $avail('mosaic_heading') ? $h('Welcome to Our Site', 'h1') : NULL,
        $avail('mosaic_text') ? $txt('Add a compelling description of your service or product here.') : NULL,
        $avail('mosaic_button') ? $btn('Get Started') : NULL,
      ]));
    }

    if ($has('feature', 'benefit')) {
      return array_values(array_filter([
        $avail('mosaic_heading') ? $h('Our Features', 'h2', 'center') : NULL,
        $avail('mosaic_text') ? $txt('Everything you need, built to work together.') : NULL,
        $avail('mosaic_columns') ? $cols(3, [
          [$card('Feature One', 'Describe your first feature here.')],
          [$card('Feature Two', 'Describe your second feature here.')],
          [$card('Feature Three', 'Describe your third feature here.')],
        ]) : NULL,
      ]));
    }

Strings shown in the user interface must be translatable.

src/Controller/ComponentPackagesController.php

Since that class does not use methods from the parent class, or it uses a single method from the parent class, it does not need to use ControllerBase as parent class.
Controllers do not need to have a parent class; as long as they implement \Drupal\Core\DependencyInjection\ContainerInjectionInterface, they are fine.

      $build['package_' . $provider] = [
        '#type' => 'details',
        '#title' => $this->t('@name (@count components)', [
          '@name'  => $moduleInfo,
          '@count' => count($components),
        ]),
        '#open'  => TRUE,
        'table'  => [
          '#type'   => 'table',
          '#header' => [
            $this->t('Plugin ID'),
            $this->t('Label'),
            $this->t('Category'),
            $this->t('Level'),
          ],
          '#rows'   => $rows,
          '#empty'  => $this->t('No components.'),
          '#attributes' => ['class' => ['mosaic-component-packages__table']],
        ],
      ];

For translatable strings that change basing on a number (as in this case), there is ::formatPlural().

src/Controller/EntityFieldsController.php

A controller class needs to implement \Drupal\Core\DependencyInjection\ContainerInjectionInterface.
Since its properties are private, the class can be as well final.

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries' post on Responsible maintainers
• Maintainership
• Git version control system
• Issue procedures and etiquette
• Maintaining and responding to issues for a project
• Release naming conventions.

You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank also all the reviewers for helping with these applications.

New projects must wait 10 days before opting in.

The description for the Security advisory coverage field says New projects must wait 10 days before opting into security advisory coverage. Please take this time to review writing secure code and best practices. The project has been created on May 10; that means waiting until May 20/21.