Problem/Motivation

While working on #3519934: Add ui_patterns_field_widgets sub-module, we noticed there is an issue with the Drupal 12 upgrade (and the move from Symfony 7 to Symfony 8.0).

See this commit: https://git.drupalcode.org/project/ui_patterns/-/merge_requests/372/diff...

Proposed resolution

  1. Change the way we are constructing constraints
  2. Change all info.yml to declare Drupal 12 compatibility.

Is it a breaking change? Is it preventing us to support both Drupal 11 and Drupal 12? Do we need to move to UI PAtterns 3?

Issue fork ui_patterns-3588936

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

From Core 11.4.0: https://www.drupal.org/node/3555534 / https://git.drupalcode.org/project/drupal/-/commit/2f82880037313b2948a59...

From Core 12.0.0 : https://www.drupal.org/node/3569092 / https://git.drupalcode.org/project/drupal/-/commit/aea47fe1b2bf794554898...

So I think if we increase core requirements to 11.4.0 it will be ok.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Related issues: +#3555534: Since symfony/validator 7.4: Support for evaluating options in the base Constraint class is deprecated. Initialize properties in the constructor instead., +#3569092: Update method signatures for addConstraint() and ConstraintManager::create() and remove HasNamedArguments use
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Upgrade to Symfony 7.4 happened in https://www.drupal.org/project/drupal/issues/3555526

Commit: https://git.drupalcode.org/project/drupal/-/commit/2f82880037313b2948a59...

Present In Core 11.4.0

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

https://www.drupal.org/node/3379306

grimreaper opened merge request !513

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » just_like_good_vibes
Status: Active » Needs work

WIP MR created.

I have not tested.

The main point to clarify is in src/Plugin/Context/RequirementsContextDefinition.php, I left a todo, when I encountered the problem on D12 I was not passing in this class so not sure about this change.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: just_like_good_vibes » grimreaper

  • grimreaper committed 4f683a9f on 2.0.x 
    task: #3588936 Drupal 12 compatibility and Symfony Constraint API

By:...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.