Problem/Motivation

When the Gin theme is used as an admin theme for a clean site install. It tries to make calls to API that might not be available to the system at the time, e.g. site configurations or user entities/roles.

Steps to reproduce

Use Gin for a clean site install, e.g. adding the following to the distribution info.yml:

distribution:
  name: 'Custom Distribution'
  install:
    theme: gin
    finish_url: '/?tour=1'

Initially the drupalSettings for gin is simply missing, breaking the frontend.

Then as the installation goes, it fails to process other parts as well.

Proposed resolution

Add gin_preprocess_install_page() hook that sets the default drupalSettings for gin.

Add InstallerKernel::installationAttempted() checks around certain preprocess hooks e.g. gin_preprocess_html so that it bails early and doesn't attempt to do any of the extra customization logic.

Remaining tasks

Provide MR

User interface changes

N/A

Issue fork gin-3588053

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

Status: Active » Needs review