Problem/Motivation

Remaining tasks

  1. The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-claro. (For example, the CR for removing HAL)
  2. Tag this issue 'Needs release note.'
  3. Remove the extension ;-).
  4. Update update path tests as needed. See Learn how to write an automated update test.
  5. Remove references from core/phpstan-baseline.neon.
  6. Remove any spelling words specific to the extension from the dictionaries.
  7. Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.
  8. Check for references in @todo.

Release notes snippet

The Claro heme has been removed from core, and can now be installed as a contrib theme. Sites should plan to use the Default Admin theme, which is the new standard administrative experience for core.

Note that the Default Admin theme is still in beta stability as of this beta release, so additional changes and fixes may be made to it before 12.0.0.

Issue fork drupal-3584639

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Active

quietone opened merge request !17197

quietone’s picture

quietone commented

The uses in core/assets and core/profiles are words in random text. 

$ git grep -il claro
core/assets/vendor/ckeditor5/translations/es.umd.js
core/assets/vendor/ckeditor5/translations/gl.umd.js
core/assets/vendor/ckeditor5/translations/pt-br.umd.js
core/assets/vendor/ckeditor5/translations/pt.umd.js
core/modules/system/src/Install/Requirements/SystemRequirements.php
core/modules/system/system.post_update.php
core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/article_body/baking-mishaps-our-troubleshooting-tips.html
core/themes/default_admin/default_admin.post_update.php
core/themes/default_admin/tests/fixtures/implementation-name-allowlist.json
core/themes/default_admin/tests/src/Kernel/FocusColorPresetUpdateTest.php
core/themes/default_admin/tests/src/Unit/ImplementationNameTest.php
quietone’s picture

quietone commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Not much outside Claro itself and the pipeline is green, looks good to me.

  • larowlan committed 8eaf82d7 on main 
    task: #3584639 Remove the Claro theme

By: quietone
By: catch
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8eaf82d7b4f to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Remove the Claro theme » [docs gate followups] Remove the Claro theme
Status: Fixed » Needs work
Issue tags: +Needs change record, +Needs release note, +12.0.0 release notes

Couple small followup tasks. If there's a CR about deprecating Claro (which there should be) we should attach it here as well and update it.

Also in this case we should probably add a little more detail to the release note about Admin as the replacement and some language about Admin's status between now and 12.0.0.

quietone’s picture

quietone commented
Title: [docs gate followups] Remove the Claro theme » Remove the Claro theme

In all other removals from core the process has not included updating the change record for the deprecation. I'd rather not introduce that now.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Fixed

Added change record and updated snippet.

The Release notes can be further improved at #3564240: 12.0.0-beta1 release notes

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

xjm’s picture

xjm
she/her
Primary language English
commented

@quietone Usually themes are not deprecated and then removed inside like a 48 period either. :) But it might be better in the future to always make it a single CR, rather than two that will have different sets of information.

Anyway, I'm fine with leaving that out of scope here. Thanks for drafting the complete one!

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

Added what I meant to the release note.