Proposed resolution

Update to version 2.2 in module

Issue fork visual_website_optimizer-3583395

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mhh created an issue. See original summary.

mhh’s picture

mhh commented
  1. Version: 2.1 -> 2.2
  2. Removed use_existing_jquery: This setting was dropped in 2.2

mhh opened merge request !11

mhh’s picture

mhh commented
Status: Active » Needs review
mhh’s picture

mhh commented
Assigned: mhh » Unassigned

elc made their first commit to this issue’s fork.

elc changed the visibility of the branch 8.x-1.x-3583395-smartcode-2.2 to hidden.

  • elc committed 98cb8602 on 8.x-1.x authored by mhh 
    feat: #3583395 Upgrade SmartCode to version 2.2. Remove usejquery.

By:...
elc’s picture

elc commented
Version: 8.x-1.5 » 8.x-1.x-dev
Status: Needs review » Fixed

Thank you for this.

I ended up splitting up your commit into the logical changes, and adjusted the js to use the same syntax as it was previously so that only changed lines show up in the MR. It makes it easier to see where the changes are, and why they are being done instead of a single large commit that does multiple things.

I've also added a hook_update_N to remove the now defunct config value.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

sagesolutions’s picture

sagesolutions commented
Category: Task » Bug report
Status: Fixed » Needs work

I think someone forgot to test!

https://git.drupalcode.org/project/visual_website_optimizer/-/merge_requ...

-       "var account_id = {$settings['id']},{$custom_url_var}",
+      "var account_id = {$settings['id']}",

The line above is missing a comma at the end, which mangles the account_id and version into one string, causing it to not load/run properly. See below


<script type="text/javascript" id="vwoCode">window._vwo_code || (function () {var w=window,d=document;var account_id = 123456version = 2.2,settings_tolerance = 2000,library_tolerance = 2500,hide_element = 'body',hide_element_style = 'opacity:0 !important;filter:alpha(opacity=0) !important;background:none !important';/* DO NOT EDIT BELOW THIS LINE */var f=0, ...

  • elc committed 4d203921 on 8.x-1.x 
    fix: #3583395 Fix comma in SmartCode 2.2

By: sagesolutions
By: ELC
elc’s picture

elc commented
Status: Needs work » Fixed

Something has gone wrong there :/ The tester on the website showed it as working and I was able to do a test. Looks like I had the wrong version installed when I was testing. Should really add automated tests to this.

Publishing new release now.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.