Problem/Motivation

Claro is being deprecated.

$ git grep -ilw claro | grep  core/profiles 
core/profiles/demo_umami/config/install/system.theme.yml
core/profiles/demo_umami/demo_umami.info.yml
core/profiles/standard/config/install/block.block.claro_login.yml
core/profiles/standard/config/install/system.theme.yml
core/profiles/standard/standard.info.yml
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTestAssertions/testAdmin.sql
core/profiles/standard/tests/src/Traits/StandardTestTrait.php
core/profiles/tests/nightwatch_a11y_testing/config/install/system.theme.yml
core/profiles/tests/nightwatch_a11y_testing/nightwatch_a11y_testing.info.yml
$ git grep -ilw claro | grep  core/recipes
core/recipes/core_recommended_admin_theme/recipe.yml
core/recipes/standard/recipe.yml

Steps to reproduce

Proposed resolution

Change to using Default Admin and adjust failing tests accordingly.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3582101-nr-bot_gw1w9td8.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3582101

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !15268

quietone’s picture

quietone commented
Title: Make Admin the default theme in Standard profile and recipe » Make Admin the default theme in profiles and recipes
quietone’s picture

quietone commented
Status: Active » Needs work

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Not a fan of this solution at all but no field classes :(

quietone’s picture

quietone commented
Issue summary: View changes
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

I left a bunch of review comments. Many things are not testing what they are testing. One way around it could be to assert #block-default-admin-content img, #block-default-admin-content a img, #block-default-admin-content .visually-hidden and similar to scope the selectors back on admin content without needing to reintroduce the field classes.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +11.5.0 release priority
smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Addressed feedback.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3582101-nr-bot_gw1w9td8.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I think I worked out a plan for ImplementationNameTest. Please check it.

dcam’s picture

dcam commented
Status: Needs work » Reviewed & tested by the community

Looks good now.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs review

One q on the MR.

The test is brittle, so hopefully my comment provides a quick fix. If not, we can go forward with the exemptions. Ideally the test doesn't stick around long anyway, since after a certain point with gin and claro removed, it won't be that important to automate checking whether gin/claro files are being added.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Tests still pass using $name_pattern.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs review

Sorry, one more q: any reason the default admin login block was left out of the standard recipe?

smustgrave’s picture

smustgrave commented

Applied the suggestion. system\FunctionalJavascript\ThemeSettingsFormTest Don't believe is related.

  • godotislate committed dfc1cb11 on main 
    task: #3582101 Make Admin the default theme in profiles and recipes

By...
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Needs review » Patch (to be ported)

Committed dfc1cb1 and pushed to main. Thanks!

Conflict in the performance tests backporting to 11.x, so that'll need a separate MR.

quietone opened merge request !17140

quietone’s picture

quietone commented
Status: Patch (to be ported) » Reviewed & tested by the community

The backport required changes to migrate UI tests, which are no longer in main, and to performance tests. Those are all passing now so I am restoring the RTBC.

  • amateescu committed 91a722eb on 11.x 
    task: #3582101 Make Admin the default theme in profiles and recipes

By...
amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Committed 91a722e and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.