Problem/Motivation

(Taggued beta5/major because it is a fix I will need for DruaplCon Chicago demos)

Contrary to Views & Entity View buildables, Page Layout display builder is no printed with the usual page layout but in a bare bone one (without blocks and regions), this is good.

However, this "bare bone" page layout is not bare enough:

  • page.html.twig is still loaded
  • the page title is displayed.

This make the UI too busy, and generate confusion about what will be the final render.

Proposed resolution

Render Display Builder directly into html.html.twig's page slot.

The current behavior is this one:

  • entity.page_layout.display_builder route has _display_builder_route options (which may be renamed)
  • The option is caught by PageVariantSubscriber which is loading Core's simple_page plugin.

Maybe simple_page is not "simple" enough.

Remaining tasks

_display_builder_route is also used in display_builder_views.views.manage route. IS it a leftover? Can we remove it?

Issue fork display_builder-3579216

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Issue tags: +display_builder-1.0.0-beta5

pdureau opened merge request !259

pdureau’s picture

pdureau commented
Status: Active » Needs work

Done & pushed.

Because we now have 2 PageVariant plugins in the module ,I have renamed the first for clarity:

  • PageLayoutPageVariant is the new name of DisplayBuilderPageVariant
  • FullPageBuilderPageVariant : is the one added in this ticket

Let's challenge the naming if it is not clear enough yet.

Remaining work:

  • Check pipeline and documentation

    • li>

pdureau’s picture

pdureau commented
Title: Page Layout builder must be displayed without any page layout around » Page layouts must be built in a full page builder
pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review

mogtofu33 made their first commit to this issue’s fork.

  • mogtofu33 committed 02dda1c2 on 1.0.x authored by pdureau 
    feat: #3579216 Page layouts must be built in a full page builder

By:...
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.