Problem/Motivation

The article element is supposed to contain a heading. However, this element is used in node.twig even when there will be no heading.

Proposed resolution

Use div when there will be no heading.

Remaining tasks

Implement.

User interface changes

Improved HTML semantics.

API changes

None.

Data model changes

None.

Issue fork radix-3577645

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

liam morland opened merge request !163

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review

doxigo made their first commit to this issue’s fork.

doxigo’s picture

doxigo commented
Status: Needs review » Fixed

Hey Liam, thanks for the MR and a good fix. merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Fixed » Needs review

It does not appear to have been merged.

  • liam morland committed bb8d8e4e on 6.0.x 
    fix: #3577645 Use `article` element only when it will contain a heading...
doxigo’s picture

doxigo commented
Status: Needs review » Fixed

Done, thanks Liam

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.