Problem/Motivation

Setting filter_days_before to zero is supposed to mean "no filtering", but if set to zero the current day's events are filtered out.

Steps to reproduce

filter_days_before is passed unsanitized into ics-parser's iCal, which interprets the setting as "today", so the current day's events are not processed.

If combined with update_non_existent set to "Delete" we're seeing the current day's events deleted.

CommentFileSizeAuthor
#3 3577365-filter-days-before.patch7.69 KBkarlshea

Issue fork feeds_ical-3577365

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

karlshea created an issue. See original summary.

karlshea opened merge request !23

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Active » Needs review
StatusFileSize
new 3577365-filter-days-before.patch7.69 KB

Here's a patch that applies to 3.1.0—it would be great if the 3.x-dev release was enabled, it's currently not installable with composer.

ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented
Assigned: Unassigned » ben.hamelin
Status: Needs review » Reviewed & tested by the community

@karlshea thanks for this issue and the fix. Let me know if this new dev release works for you: https://www.drupal.org/project/feeds_ical/releases/3.x-dev

MR looks good, I am closing and will cut a new release

ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented
Version: 3.1.0 » 3.1.1
Status: Reviewed & tested by the community » Fixed

Fixed and released with 3.1.1

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

Thanks Ben!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.