Problem/Motivation

Move tests of Search functionality to the Search module.

Steps to reproduce

Proposed resolution

  • core/modules/node/tests/src/Functional/NodeTranslationUITest.php
  • core/modules/page_cache/tests/src/Functional/PageCacheTagsIntegrationTest.php
  • core/modules/search/tests/src/Functional/SearchEntityOperationsCacheabilityTest.php
  • core/modules/search/tests/src/Functional/SearchNodeTranslationUITest.php
  • core/modules/search/tests/src/Functional/views/ViewsIntegrationTest.php
  • core/modules/search/tests/src/Functional/views/ViewsMultilingualTest.php
  • core/modules/search/tests/src/Kernel/node/NodeSearchTest.php
  • core/modules/system/tests/src/Kernel/Entity/EntityOperationsCacheabilityTest.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575605

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes

quietone opened merge request !14906

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Looks like a good chunk of tests. See nothing more to contribute

catch closed merge request !14906

  • catch committed 983ba364 on main 
    task: #3575605 Move tests of search to search module

By: quietone
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 41d059ef on 11.x 
    task: #3575605 Move tests of search to search module

By: quietone
(...

  • catch committed f980c1b4 on 11.x 
    Revert "task: #3575605 Move tests of search to search module"

This...

  • catch committed 02252678 on main 
    Revert "task: #3575605 Move tests of search to search module"

This...
catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Needs work

This introduced some namespace mis-matches which weren't caught but the original MR run, see this against 11.x https://git.drupalcode.org/project/drupal/-/pipelines/783195/test_report...

Reverting for now so we can fix them here prior to recommit.

smustgrave opened merge request !15289

smustgrave’s picture

smustgrave commented

Felt obligated to try and fix as I RTBC it. And see that core/modules/search/tests/src/Functional/SearchNodeTranslationUITest.php was pointed to node

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

No more namespace problem.

  • catch committed 138f0ddc on 11.x 
    task: #3575605 Move tests of search to search module

By: quietone
By:...

  • catch committed e46037bc on main 
    task: #3575605 Move tests of search to search module

By: quietone
By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Let's try again.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !15289

  • catch committed 256f3f81 on 11.x 
    task: #3575605 Move tests of search to search module

By: quietone
By:...

  • catch committed d8ea980e on main 
    task: #3575605 Move tests of search to search module

By: quietone
By:...

  • catch committed 4177d07c on 11.x 
    Revert "task: #3575605 Move tests of search to search module"

This...

  • catch committed 5d40fdcc on 11.x 
    Revert "task: #3575605 Move tests of search to search module"

This...

  • catch committed 3b0329cc on main 
    Revert "task: #3575605 Move tests of search to search module"

This...

  • catch committed c7f5f7f3 on main 
    Revert "task: #3575605 Move tests of search to search module"

This...
catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Needs work

No that didn't fix it. Not sure why the MR runs are passing then this only shows up on MR runs against 11.x in different issues.

ViewsMultilingualTest is also in the wrong namespace.

quietone reopened merge request !15289

quietone’s picture

quietone commented
Status: Needs work » Needs review

Trying again

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Sorry about that I shouldn’t have relied on the green MR yesterday.

Third time is the charm.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

MR looks like it still has the same issue to me.

smustgrave’s picture

smustgrave commented

OH dammit I'll fix as it might be the AM for quietone

smustgrave’s picture

smustgrave commented

Also fixed SearchEntityOperationsCacheabilityTest and NodeSearchTest

Lets see what the pipelines say.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

that better?

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Still doesn't look right to me - see comments on the MR.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Not again!

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Is anyone concerned that the pipeline is green every time?

catch’s picture

catch
he/him
Primary language English
commented

It looks like the test coverage we have for this only works on 11.x and not 12.x, this test kept causing test failures on the 11.x backport of #3390193: Add a drupalGet() method to KernelTestBase. I think we should open a new issue to investigate why it's passing against main.

Haven't reviewed the latest version yet.

smustgrave’s picture

smustgrave commented

Rebased

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Needs work

Reviewed the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Pushed the feedback.

  • amateescu committed 53a3a0d4 on main 
    task: #3575605 Move tests of search to search module

By: quietone
By:...
amateescu’s picture

amateescu commented
Status: Needs review » Patch (to be ported)

Committed 53a3a0d and pushed to main. Thanks!

We need a 11.x MR here because the phpstan baseline change doesn't apply.

quietone opened merge request !15410

quietone’s picture

quietone commented
Status: Patch (to be ported) » Reviewed & tested by the community

Restoring RTBC because the rebase only required the baseline to be rebuilt.

  • amateescu committed 597ab5ec on 11.x 
    task: #3575605 Move tests of search to search module

By: quietone
By:...
amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Committed 597ab5e and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

amateescu closed merge request !15410

amateescu closed merge request !15289