Problem/Motivation

In #3159848: [Policy] Always install Drupal with Standard on the UI, pared down of use case specific elements (content types, node listing, commenting, theme) we are planning to remove the standard install profile and merge it with minimal to create a starter recipe. One thing that's not in the standard profile but assumes the intent of the standard profile is the default /node listing in node module, which is created as a view. This is present on Drupal sites even if they don't intend to have a simple blog like listing and some people forget to remove it or disable it.

Steps to reproduce

Install with the standard profile before and after this MR :)

Proposed resolution

  • Disable the /node default listing. (Removing it would be very tricky due to lots of test dependencies)
  • Rename this view from Frontpage to Promoted content.
  • Add a controller that's a welcome page and set that as the front page.
    • Name the page welcome-to-drupal so it is not in the way later on even when it is not available anymore. (A more generic welcome route could conflict even with existing sites).
    • Add text on that page based on Olivero's getting started page that tells you to set a new front page with a link to the config for it.
    • Access to that routes depends on whether this path is the front page or not. It should 404 when this is not the front page anymore.. So it practically disappears when the front page is configured.
  • Update all the tests to explicitly enable the promoted content view where they need it. Most tests also need a route rebuild so the routes become available.
  • Update the Olivero nightwatch tests to test the front page instead of the /node page because the long text now appears on the front page (for testing scrolling).

Remaining tasks

Review!

User interface changes

  1. New default front page in the standard profile is not a node listing but a welcome page. (Minimal still has user/login as the front page)
  2. Promoted content view available as disabled, don't need to disable it if you don't want to use it.

BEFORE:

AFTER:

Introduced terminology

None.

API changes

None.

Data model changes

None.

Release notes snippet

The default node listing page is not the default frontpage of Drupal's standard profile anymore. The view providing this page (and a default RSS feed) is still available but is disabled by default.

LLM disclosure

LLM was used to accelerate the development of this MR, everything was deeply reviewed though.

Issue fork drupal-3572350

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

gábor hojtsy created an issue. See original summary.

gábor hojtsy’s picture

Summary was based on slack discussion with @catch, so added him to the contribution record :)

gábor hojtsy’s picture

I should disclose that my contribution on this issue is LLM assisted (and closely reviewed).

gábor hojtsy’s picture

Title: Remove the default /node listing view and add a better default front page for new installs » Disable the default /node listing view and add a better default front page for new installs
Issue summary: View changes

Retitling new target discussed with @catch, instead of removing the view, making it disabled to start, since that lowers the required test changed significantly. It is still not the default Standard front page anymore in the MR. Will see if we get to a complete MR sooner with this. Fingers crossed.

gábor hojtsy’s picture

Status: Active » Needs review

I believe this is now down to a random fail :) Yay! Please review!

gábor hojtsy’s picture

Issue summary: View changes

Heavy issue summary update.

gábor hojtsy’s picture

Issue summary: View changes
StatusFileSize
new496.06 KB
gábor hojtsy’s picture

Issue summary: View changes
StatusFileSize
new445.06 KB

Adding a before screenshot too.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

gábor hojtsy’s picture

gábor hojtsy’s picture

Status: Needs work » Needs review
acbramley’s picture

Status: Needs review » Needs work

Left some comments

acbramley’s picture

Status: Needs work » Needs review

Actioned my own feedback, I used ClaudeAI to refactor the trait.

gábor hojtsy’s picture

@acbramely: woah, thanks for the refactor, I think this makes it much easier to read and review :) Yay! I think all your changes look great.

dww’s picture

Not a super thorough review, but spotted a few things I wanted to open threads about. Not worth NW over any of them.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new98 bytes

The Needs Review Queue Bot tested this issue. The merge request has merge conflicts and cannot be merged. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

gábor hojtsy’s picture

Status: Needs work » Needs review

Rebased, green again! Also resolved all concerns from @phenaproxima.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new1.2 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

acbramley’s picture

Status: Needs work » Needs review

Fixed attribute