Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
As a result of the change of the minimum supported core version to 10.3 in parent issue #3565209: [Meta] Drop support for Drupal 10.2 and below, we should now be able to implement autowiring for services and controllers, as suggested in change records:
- Services can be autowired, as of 9.2.x.
- Controllers can be autowired and a create() method is no longer always necessary, as of 10.2.x.
Steps to reproduce
Proposed resolution
Impacted files:
- services yaml files: Add
autowire: trueand remove arguments:
admin_toolbar_search.services.yml and admin_toolbar_tools.services.yml. - Services and Controller class files: Add
use AutowireTraitand update constructors to autowire services:
AdminToolbarSearchController, AdminToolbarToolsHelper.
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork admin_toolbar-3570710
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
dydave commentedQuick follow-up on this issue:
All the changes detailed in the issue summary have been implemented and described in the merge request MR !203 above at #2.
Since all the tests and jobs still seem to be passing 🟢, moving issue to Needs review as an attempt to get more testing feedback and reviews.
These changes require Drupal core 10.2 or higher and should probably be merged after related:
#3569351: Drop support for Drupal 10.2 and below
Feel free to let us know if you have any comments, questions or concerns on any aspects of this issue or the suggested changes in the merge request, we would surely be glad to help.
Thanks in advance!