Problem/Motivation

Commonly, core and contrib composite field widgets are wrapped in a fieldset element.

Steps to reproduce

  1. Add a Date and/or an Address field to a content type.
  2. Visit the Node add form.
  3. Note the difference in the DOM for the other composite fields.

Proposed resolution

Wrap the Name field component fields in a <fieldset> with the Label in a legend as provided by Drupal core.

Remaining tasks

TBD

User interface changes

The Name fields in a form display are wrapped in a <fieldset> element.

API changes

None.

Data model changes

None.

Issue fork name-3568633

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jcandan created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Changed the Name element's theme wrapper from `form_element` to `fieldset`, which wraps the name components in a `` with the label displayed as a ``, matching the pattern used by Address and Date fields.

nickolaj opened merge request !67

bluegeek9’s picture

bluegeek9 commented
Status: Needs review » Needs work

Two of the tests failed.

bluegeek9’s picture

bluegeek9 commented
Status: Needs work » Closed (works as designed)

You can add a fieldset with the field greop module. We will not add it to the name project.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jcandan’s picture

jcandan commented

This is disappointing considering UI Standards docs and the field label (legend) and wrapper consistent with other composite fields.

bluegeek9’s picture

bluegeek9 commented
Status: Closed (works as designed) » Active

bluegeek9 changed the visibility of the branch 8.x-1.x to hidden.

bluegeek9’s picture

bluegeek9 commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • bluegeek9 committed b15cb118 on 8.x-1.x authored by nickolaj 
    Issue #3568633: Changed the Name element's theme wrapper from `for...
jcandan’s picture

jcandan commented

Oooh, re-reading my comment in #8, I realized that could have come across fairly sharp. It may have been better to phrase that as reasoning in an issue description update rather than as a disappointment. Thanks for doing this!

bluegeek9’s picture

bluegeek9 commented

Don't worry about it.

bluegeek9’s picture

bluegeek9 commented
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including: