Problem/Motivation

Make compatible with Drupal 11.

Automated fixes have already been completed in #3428536: Automated Drupal 11 compatibility fixes for config_distro.

Proposed resolution

Fix these issues:

  • src/Form/ConfigDistroImportForm.php: Access to an undefined property Drupal\config_distro\Form\ConfigDistroImportForm::$configManager
  • tests/src/Unit/DistroStorageManagerTest.php: Access to an undefined property Drupal\Tests\config_distro\Unit\DistroStorageManagerTest::$memoryStorage.

These are caused by changes in the core classes that config_distro extends.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork config_distro-3566230

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes

joegraduate made their first commit to this issue’s fork.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Category: Task » Bug report
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Title: Make compatible with Drupal 11 » Fix remaining Drupal 10/11 compatibility issues

joegraduate opened merge request !29

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Reviewed & tested by the community

Looks good. There is no third param to StorageComparer::__construct(). All checks are passing. Thanks

  • joegraduate committed 04ae0abc on 2.1.x 
    fix: #3566230 Fix remaining Drupal 10/11 compatibility issues

By: liam...
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Reviewed & tested by the community » Fixed

Merged.

Thanks for reporting @liam morland!

Looks like we missed the issue in ConfigDistroImportForm when we dropped D9 compatibility. The relevant core change was part of #2993271: Remove unused ConfigManager dependency in StorageComparer.

I believe the other PHPstan failure only exists in the MR branch for #2959209: Create rigurous tests. I pushed a change to the MR branch in that issue to address that one.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Related issues: +#2993271: Remove unused ConfigManager dependency in StorageComparer

  • joegraduate committed 15354c94 on 2.0.x 
    fix: #3566230 Fix remaining Drupal 10/11 compatibility issues

By: liam...
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented

Backported to 2.0.x since technically this was a Drupal 9+ compatibility fix.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Title: Fix remaining Drupal 10/11 compatibility issues » Fix remaining Drupal 9+ compatibility issues

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.