Problem/Motivation

Currently, src/AutologoutManager.php typehints all injected services except SessionManager with an interface. This can run into trouble with modules that override/decorate the SessionManager implementation.

Proposed resolution

Typehint SessionManager using SessionManagerInterface.

Remaining tasks

- test
- review
- merge

User interface changes

none

API changes

none

Data model changes

none

Issue fork autologout-3565274

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fskreuz created an issue. See original summary.

fskreuz opened merge request !86

fskreuz’s picture

fskreuz commented
Issue summary: View changes
vishal choudhary’s picture

vishal choudhary
Location Dharmshala
commented

Automated Logout fails on Drupal future versions due to concrete SessionManager type-hint; update to SessionManagerInterface
@fskreuz good catch.

fskreuz’s picture

fskreuz commented
Status: Active » Needs review
asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

I've tested MR and looks good to me.

the_g_bomb made their first commit to this issue’s fork.

the_g_bomb’s picture

the_g_bomb commented

Brought the branch up to date and tested, confirmed works as expected
RTBC +1

the_g_bomb’s picture

the_g_bomb commented

Merged

the_g_bomb’s picture

the_g_bomb commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • the_g_bomb committed 3ad2428a on add_csrf_protection authored by fskreuz 
    Issue #3565274: Typehint SessionManager using its interface

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.