Problem/Motivation

QuizAccessDeniedSubscriber logs every 404 exception. This can quickly clutter the logs, especially for larger sites. Aside from that the resolution of https://www.drupal.org/node/3498572 is suboptimal as it bypasses the core CustomPageExceptionHtmlSubscriber in favour of an own implementation which would need to be kept updated.

Steps to reproduce

Install the quiz module & make 404 requests.

Proposed resolution

Instead of simply removing the logging line, I think it'd be better to take the approach of webform. By implementing the onException method the other 4xx implementations remain defaulted. That way the core CustomPageExceptionHtmlSubscriber::on404 will be executed again.

CommentFileSizeAuthor
#3 3565063-1.patch2.11 KBduivw

Issue fork quiz-3565063

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

duivw created an issue. See original summary.

duivw’s picture

StatusFileSize
new2.11 KB

Attached patch of the MR

smustgrave made their first commit to this issue’s fork.

  • smustgrave committed dccb9abc on 7.1.x
    feat: #3565063 QuizAccessDeniedSubscriber clutters logs
    
    By: duivw
    

  • smustgrave committed 5313cf1c on 8.0.x
    feat: #3565063 QuizAccessDeniedSubscriber clutters logs
    
    By: duivw
    
smustgrave’s picture

Version: 7.0.x-dev » 8.0.x-dev
Status: Active » Fixed

Thanks have included in relevant branches!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.