Problem/Motivation

Some block are not working on render and preview tabs.

Entity display: Fields image, token
Views display: Views rows
Page Display: We have a preview replacement, should we make it generic?

Steps to reproduce

  • Create an entity display with image (article from standard profile)
  • The image sample is generated
  • Remove this image field
  • Add a block fields > image

No sample is generated on "render", on preview tab it's empty

Problem wit token in Entity display:

  • Create an entity display
  • Add a token with text

The Token is not renderer (stay label Token : my text) and not on preview

Proposed resolution

Have a fallback preview for these blocks? Like for page layout, concerned are (Views rows, an perhaps others)

Remaining tasks

User interface changes

API changes

Data model changes

Comments

mogtofu33 created an issue. See original summary.

mogtofu33’s picture

mogtofu33 commented
Assigned: Unassigned » just_like_good_vibes
Issue tags: +beta blocker
Parent issue: » #3561038: [Meta] Multiple fixes for beta1
pdureau’s picture

pdureau commented

My feedback from #3561038: [Meta] Multiple fixes for beta1:

  • Entity display: Tokens >> 🔥 I am reproducing
  • Entity display: Fields image >> 🔥 I am reproducing. Discussed in UI Patterns weekly. It may be related to FieldItemInterface::generateSampleValue() with entity reference fields.
  • Views display: Views rows >> Is it already covered by this issue #3542796: Preview of view sources planned for a later beta release?
pdureau’s picture

pdureau commented
Issue tags: +display_builder-1.0.0-beta1
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

hello, just tested with the image field on article.
i couldn't reproduce it. i remove and re-add the image, it is shown again.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

i identified the token problem #3562086: Token source : improve preview

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Related issues: +#3562086: Token source : improve preview
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » mogtofu33

i propose to postpone this issue to beta2 if you all agree.
By the way, #3562086: Token source : improve preview will fix the empty token sources in preview and improve the render of token sources in build mode.

@mogtofu33 i let you postpone that one after beta1 :)

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Active » Closed (won't fix)
Issue tags: -beta blocker, -display_builder-1.0.0-beta1

The field image seems related to prod mode when the generated sample is not good sometimes.
Dev tools provide a refresh sample, but that's annoying.

Blocks (Views row, Page title...) are replaced with a placeholder until we have a better solution.

As textfield is working, will remove token for now like Wyswiyg.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.