Workflow for these issues

Create a child issue when fixing an issue from the list and append it.

Update documentation

  • Drupal version, patches, aggregation, cache... Done!

Critical Bug

Medium Bug

Low bug

These smaller fixes can be done in this issue directly.

  • Full screen in/out drawer: top margin and wrong offset (missing fallback var) Done!
  • Dark mode toolbar missing parts Done!
  • Contextual copy/duplicate not in place Done!
  • On layers when Drag cannot scroll done partially, need slow move...
  • When click on tree, highlight should scroll Done!

Important features

Nice to have features

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mogtofu33 created an issue. See original summary.

mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Title: Multiple fixes for beta1 » [Meta] Multiple fixes for beta1
Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
pdureau’s picture

Update documentation

We have a post-beta1 ticket for that: #3546356: Update documentation

Critical bug

Wait for ui patterns release that include variant_id fix

It is only a warning, and out of Display Builder scope, so not a beta1 blocker in my opinion.

Token render and preview not working on entity display

🔥 I am reproducing and I agree it must be addressed in beta1 scope.

Drag problem: after adding a style to a component, cannot drag in other slot

I am not reproducing this one. Which component are you testing with?

WYSIWYG block do not load CkEditor in instance form (right drawer) properly

🔥 It may worth to try with #3535999: Render UI with both front and admin theme which is displaying the full form in the admin theme, isolated in a shadow dom, so it must work in a more expected way.

Page layout: Publish and restore buttons are always enabled even if current is published version, related to #3549867: First step is not properly savable

🔥 Indeed, it looks related to #3549867: First step is not properly savable which is a nice-to-have for beta1. Maybe we can have a look on why the phpunit fails there and merge it for beta1.

Page layout: Apply a style to a component, the response in xhr contain error: Drupal\Core\Render\Element\ComponentElement::generateComponentTemplate(): Argument #1 ($id) must be of type string, null given, called in /var/www/html/web/core/lib/Drupal/Core/Render/Element/ComponentElement.php on line 81

Could be seen on preview panel.

I am not reproducing this one. Which component are you testing with?

Entity: All fields entity preview are not working (broken...)

🔥 Indeed, they are broken in the preview on hover in the block library. Is its something easy and quick to fix or do we need to address this in beta2?

Low bug

Libraries drawer (left): if filter set on components and switch, block list will be filtered without the text filled

I am not reproducing and I agree it is low priority subject.

Out of full screen after opening drawer, the top margin is behind toolbar

I am reproducing and I agree it is low priority subject.

just_like_good_vibes’s picture

Hello,
can we move some of them for a beta2?
we really need a tagged milestone, which ones are really required for tag beta1?

mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes

  • mogtofu33 committed 2c61de4c on 1.0.x
    doc: #3561038 Update required Drupal version to 11.3
    
    By: mogtofu33
    

  • mogtofu33 committed d6c06f92 on 1.0.x
    fix: #3561038 Remove tree, tokens and visibility from default profile....
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
just_like_good_vibes’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes

mogtofu33 changed the visibility of the branch 3561038-beta-fixes to hidden.

pdureau’s picture

Following the updates of issue description.

Critical Bug

#3557682: Undefined array key "variant_id" in ComponentSource::settingsSummary() (better if hotfix alone as dev is currently slower)

No need to wait to tag beta1 because we are not pinning the ui_patterns dependency, right? With "drupal/ui_patterns": "^2.0.12", a project doing a composer update will get 2.0.13 and further... am I right?

UI styles when apply with Bootstrap is slow (500-700ms): could be it apply and update everything and not only the target

I am not reproducing this:

  • ✅ between 150ms and 220ms even with both UI Suite DaisyUI & UI Suite Bootstrap installed.
  • ✅ the OOB swap replace only the expected component

#3561447: Render and preview not working

Entity display: Tokens >> 🔥 I am reproducing

Entity display: Fields image >> 🔥 I am reproducing. Discussed in UI Patterns weekly. It may be related to FieldItemInterface::generateSampleValue() with entity reference fields.

Views display: Views rows >> Is it already covered by this issue #3542796: Preview of view sources planned for a later beta release?

#3561411: Drag problem: after adding a style to a component, cannot drag in component slot

I am still not reproducing this one.

#3561474: WYSIWYG block behavior problems with ajax

Not checked yet.

Page layout: #3549867: First step is not properly savable

🔥 I am reproducing this one and I agree it is beta1 priority.

#3561476: Beta fixes on search, preview

Not checked yet.

Preset name do not handle special chars, one with utf8 will crash all builders: Unable to encode schema array as JSON: Malformed UTF-8 characters, possibly incorrectly encoded

🔥 I am reproducing this one and I agree it is beta1 priority.

Medium Bug

WYSIWYG popup (like link or table) do not show

I am reproducing this one

#3561312: Page conditions for content type

Not checked yet.

UI Suite DSFR: Instance form checkbox styled by dsfr.js, to see after #3535999: Render UI with both front and admin theme

I also hope #3535999: Render UI with both front and admin theme will fix this.

mogtofu33’s picture

Issue summary: View changes

mogtofu33 changed the visibility of the branch 3561038-beta-fixes to active.

  • mogtofu33 committed 0a6a4c19 on 1.0.x
    fix: #3561038 layers and instance admin page
    
    by: mogtofu33
    

  • mogtofu33 committed b294648d on 1.0.x
    fix: #3561038 layers fix, add description switch
    

mogtofu33 changed the visibility of the branch 3561038-beta-fixes to hidden.

  • mogtofu33 committed 463f693c on 1.0.x
    feat: #3561038 instance list filters, preview blocks, layers fixes
    
    by:...
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes

mogtofu33’s picture

Issue summary: View changes

mogtofu33’s picture

Issue summary: View changes

  • mogtofu33 committed f8a32cfd on 1.0.x
    fix: #3561038 drawer and toolbar z-index, update views test
    

  • mogtofu33 committed c609412d on 1.0.x
    chore: #3561038 some styling changes and optimization
    
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes

  • mogtofu33 committed 71b529f8 on 1.0.x
    chore: #3561038 Entity override deletion
    
    by: mogtofu33
    
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes

mogtofu33’s picture

Issue summary: View changes

  • mogtofu33 committed fe459536 on 1.0.x
    doc: #3561038 update documentation and bump versions
    
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Assigned: Unassigned » mogtofu33
Issue summary: View changes

  • mogtofu33 committed 0bb84ec3 on 1.0.x
    fix: #3561038 some css issue on drag and sticky toolbar
    
mogtofu33’s picture

Issue summary: View changes

  • mogtofu33 committed e39cba7b on 1.0.x
    fix: #3561038 ui style fixes, prepare tree move
    
mogtofu33’s picture

Issue summary: View changes

  • mogtofu33 committed 36f04a80 on 1.0.x
    feat: #3561038 scroll when higlight from tree
    

  • mogtofu33 committed 21056a9f on 1.0.x
    fix: #3561038 copy paste fix and some layers css
    

mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Status: Active » Needs review

Beta 1 is ready, let's go!

  • mogtofu33 committed f2718cf5 on 1.0.x
    fix: #3561038 module required for islands
    
    by: mogtofu33
    

  • mogtofu33 committed a8facaef on 1.0.x
    chore: #3561038 ui_styles must be a dependency
    
mogtofu33’s picture

Issue summary: View changes

  • mogtofu33 committed e9b068c8 on 1.0.x
    chore: #3561038 typo, perf refactor, ui patterns patch url
    

  • mogtofu33 committed 29983212 on 1.0.x
    chore: #3561038 add highlight and drawer size memory
    

  • mogtofu33 committed 16a26da3 on 1.0.x
    chore: #3561038 fix tree and selection highlight
    
mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.