Problem/Motivation

Sometimes a message is so important the user shouldn't be able to remove it.

Steps to reproduce

Proposed resolution

Add config option to disable close button.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 message_banner-3561379.patch680 bytesefpapado

Issue fork message_banner-3561379

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

imclean created an issue. See original summary.

imclean opened merge request !7

imclean’s picture

imclean commented
Status: Active » Needs review

The MR seems to include a previous commit unrelated to this feature request.

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented
Version: 2.0.x-dev » 3.0.x-dev
Assigned: Unassigned » sophie.sk
Status: Needs review » Needs work
sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented
Status: Needs work » Fixed

Resolved in 3.0.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • sophie.sk committed 6d958b3d on 3.0.x 
    feat: #3561379 Add option to disable close button

By: imclean
By:...

sophie.sk closed merge request !7

efpapado’s picture

efpapado commented
Status: Fixed » Needs review
StatusFileSize
new message_banner-3561379.patch680 bytes

The feature does not work on 3.0.0. The necessary parts from hook_theme and hook_page_attachments are missing. Uploading a patch here, because gitlab seems to have some issues now. I'll create a MR when it's back in order.

efpapado opened merge request !9

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks for the fix @efpapado - I did make both of these changes when I added this feature, but clearly missed them when committing!

merging the PR and I'll roll a new version. Thank you :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.