Problem/Motivation

https://github.com/ckeditor/ckeditor5/releases/tag/v47.3.0

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3561212

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

longwave opened merge request !14027

longwave opened merge request !14028

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

If you want to reproduce locally here's what I did:

First, edit core/package.json and set version numbers for all ckeditor5 packages. Then

cd core
yarn
yarn vendor-update
yarn build:ckeditor5
godotislate’s picture

godotislate
he/him
commented

I matched the 11.x and 10.6.x diffs locally running the steps in #5. One note is that the yarn run build:ckeditor5-types from https://www.drupal.org/about/core/policies/core-change-policies/frontend... was skipped. If I add that step, there are changes to core/modules/ckeditor5/js/build/ckeditor5.types.jsdoc, though as I recall
from #3538768-18: Update CKEditor 5 to 47.0.0, we probably want to drop the jsdoc? If so, this lgtm.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Oh whoops I forgot about the types. Let's update those too while they are still here.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Related issues: +#3551053: Remove jsdoc integration for CKEditor5

Pushed. Let's keep the docs up to date until #3551053: Remove jsdoc integration for CKEditor5 is decided; next time I will try to remember this.

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

Tests are green, so lgtm

  • catch committed 1b3d669d on 11.3.x 
    task: #3561212 Update CKEditor 5 to 47.3.0

By: longwave
By: godotislate...

  • catch committed 3e1f27e4 on 11.x 
    task: #3561212 Update CKEditor 5 to 47.3.0

By: longwave
By: godotislate

catch closed merge request !14028

catch closed merge request !14027

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.6.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x/11.3.x and 10.6.x respectively, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed b8fad3b8 on 10.6.x 
    feat: #3561212 Update CKEditor 5 to 47.3.0

By: longwave
By: godotislate

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.