Problem/Motivation

Discovered while testing #3538768: Update CKEditor 5 to 47.0.0, it's not clear if ckeditor5.types.jsdoc is actually needed any more.

It was originally added in #3248423: Decide how CKEditor 5-provided types should be referenced to help CKEditor5 plugin authors refer to the CKEditor API, but in local testing if I delete the file then PHPStorm can still reference parts of the CKEditor5 API - it seems to do this through the TypeScript declarations that are provided with newer versions of CKEditor.

Steps to reproduce

Proposed resolution

Remove ckeditor5.types.jsdoc and the associated build script.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3551053

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: » #3449808: [12.x] [meta] Requirements for tagging 12.0.0-beta1

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Closed (won't fix)

#3587182: Update CKEditor 5 to 48.0.1 fixes the script so we can continue using it. It might still have some value as the Drupal plugins don't use TypeScript, so let's keep it for now.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

xjm’s picture

xjm
she/her
Primary language English
commented
Parent issue: #3449808: [12.x] [meta] Requirements for tagging 12.0.0-beta1 »