Remove words not needed in cspell:ignore

Seems some additional spaces were added in the navigation.css, seems minor but now the comments appear to be floating from the css block they're suppose to be on.

If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Changes seem fine. Going to mark so you don't have to re-run again hopefully.

Looking at the attached script, I see that it identifies words that appear only once, in a cspell:ignore comment, so they are never used.

That means the script will miss words that appear in two such comments, or words that do not need to be ignored because of updates to the dictionaries. That includes whatever dictionaries cspell uses by default and our custom dictionaries. I noticed some unnecessary // cspell:ignore quux lines while reviewing #3619969: Fix StaticMap migrate process plugin doc variable names.

I suggest a couple of updates to the attached script for next time:

1. Count how many times a word appears in the file and compare it to the number of times it appears preceded by cspell:ignore.
2. Generate a list of all the words in cspell:ignore comments for further inspection.

After (2), we could save the list to a file and run cspell on it. Any word that is not flagged is one that does not need a cspell:ignore comment.

I found a lot more words to remove with a different approach. The steps are:

1. strip all cspell:ignore comments
2. run cspell on the changed files
3. gather all the violations
4. restore the cspell:ignore comments, with non-violations removed
5. rerun cspell

This passed in CI, but I'm setting NW so I can contribute the script back. It was generated by an LLM and I'd like to provide a human readable version of it.

OK here's the script. It includes a --fix option and runs phpcbf and prettier afterwards. Running against main removes 154 words. Running against 789e79f8 removes 81 words.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Rebased. Not sure it was really necessary of if review bot was having a moment.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Despite what the bot said, the CI pipeline passes, including PHPStan.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Bot is confused.

I reviewed the files in batches:

29 under core/modules/ckeditor5/
39 under core/modules/ excluding the first group
20 under core/tests
23 not in any of those groups

In all cases, I confirmed that there were only the expected changes. Some words were removed, some cspell:ignore lines were removed (sometimes along with a neighboring empty line), some cspell:ignore lines were combined after some of the words were removed. The CI job shows that the cspell test still passes, so that is good enough for me.

There were a few places where long lines (more than 80 characters) were replaced by shorter lines, so that is a bonus. There were a few places where two cspell:ignore lines could have been rewrapped. I commented on one such pair just to prove that I was thorough in my review.

Some commas were removed, and a stray single quote ('). So were the instances of "quux" that I mentioned in Comment #12.

I was almost ready to change the status to RTBC, but some of the last few files I reviewed (under core/themes/) had a few problems that I think are worth fixing. See the MR comments.

Opened #3628986: t() signature in update-countries.sh should match t() in bootstrap.inc so review bot and commit-code-check won't complain about this.