Problem/Motivation

Several linters in the GitLab CI pipeline (cspell, eslint, phpcs, phpstan, phpstan previous major, and stylelint) are running but not configured to fail the pipeline when they detect problems. This allows lint errors to accumulate unnoticed, reducing code quality and making it harder to trace when issues were introduced.

Proposed resolution

  • Update the GitLab CI configuration so each linter is allowed to fail only when appropriate, and otherwise fails the pipeline.
  • Fix the existing violations reported by these linters.
  • Ensure future merge requests surface lint failures clearly.

Remaining tasks

  • Review the current CI configuration for each linter.
  • Enable required failure behavior.
  • Run the linters locally or via CI to gather the current set of violations.
  • Create or update patches to fix the reported issues.
  • Request code review.

Issue fork markdown-3560616

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

Status: Active » Needs review
joelpittet’s picture

Status: Needs review » Fixed

The linters will be committed unless the train stops.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • joelpittet committed 48b195cb on 3.0.x
    feat: #3560616 Enable failing cspell, phpcs, and stylelint linters in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.