Problem/Motivation

The GitLab continuous integration (CI) pipeline is showing warnings (https://git.drupalcode.org/project/nanobanana_editor/-/pipelines/670538) due to multiple global code quality issues, reported by various validation tools, such as cspell, eslint, phpcs, phpstan, and stylelint.

These warnings and errors appear throughout the module and prevent the pipeline from completing successfully.

This issue aims to perform a complete code quality cleanup across the entire module to align it with Drupal standards and the project's automated linting rules.

Steps to follow

  1. Run the GitLab continuous integration pipeline or run the validation jobs locally:
  • cspell .
  • eslint.
  • phpcs --standard=Drupal,DrupalPractice .
  • phpstan analyze
  • stylelint "**/*.css"
  • Review the warnings and errors reported by each tool.
  • Proposed solution

    Apply global code quality fixes across the entire repository:

    • Correct spelling errors detected by cspell.
    • Resolve JavaScript style and syntax issues detected by eslint.
    • Apply Drupal coding standards using phpcbf and manually fix remaining phpcs issues.
    • Address static parsing errors reported by phpstan.
    • Correct CSS formatting and rules violations detected by stylelint.

    After applying all fixes, rerun the pipeline to confirm that all validation jobs have completed successfully.

    Command icon Show commands

    Start within a Git clone of the project using the version control instructions.

    Or, if you do not have SSH keys set up on git.drupalcode.org:

    Comments

    diegodz created an issue. See original summary.

    diegodz’s picture

    Issue summary: View changes

    adicc made their first commit to this issue’s fork.

    • adicc committed 8363f4e6 on 1.0.x
      Resolve #3559828 "Coding standards fix"
      
    adicc’s picture

    Status: Active » Fixed

    Now that this issue is closed, review the contribution record.

    As a contributor, attribute any organization that helped you, or if you volunteered your own time.

    Maintainers, credit people who helped resolve this issue.

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.