Problem/Motivation

It could be useful to refactor the SA data in get_cwe_capec_from_advisory_url() to be resuable.

Proposed resolution

Move the SA data from get_cwe_capec_from_advisory_url into a separate file, then load it when needed.

Remaining tasks

Move the data from get_cwe_capec_from_advisory_url() into a separate file.

User interface changes

n/a

API changes

TBD

Data model changes

TBD

Issue fork securitydrupalorg-3557186

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

damienmckenna opened merge request !18

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
Status: Active » Needs review

This moves the SA data into a separate JSON file, so we only have to manage that text file.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

This looks good to me. I reviewed a few items in the transition and also the updated logic.

Thanks for your help to make this easier to maintain and more generally useful.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.