I don't see a reason for the jquery_ui dependency

Replacing jQuery with Vanilla JS is the way to go to remove another dependency.

Issue fork basic_cart-3556730

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

norman.lol created an issue. See original summary.

norman.lol opened merge request !22

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Category: Bug report » Task
Status: Active » Needs review
norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

I removed jquery_ui from the info.yml and added a composer.json that still lists jquery_ui as a dependency to prevent jquery_ui from being removed from composer.lock file and by that from the file system on the next composer update. Otherwise just removing it from the info.yml would leave people with a missing module that can't be uninstalled anymore.

jquery_ui will then ultimately be removed from the composer.json on the next major release.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Needs review » Fixed

Will release 8.x-8.8 now.

Created change record #3556817: Basic Cart dropped jquery_ui dependency.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • norman.lol committed bf6fd19a on 8.x-8.x 
    #3556730 Default to 1 quantity and prevent JS error

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.