Closed (duplicate)
Project:
Better Exposed Filters
Version:
7.1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Oct 2025 at 15:07 UTC
Updated:
19 Nov 2025 at 23:18 UTC
Jump to comment: Most recent, Most recent file
Show commands
changes
Comments
Comment #2
mdranove commentedComment #3
mdranove commentedComment #5
mdranove commentedOk so I've pushed up a fix. There's a test for this that already exists in Option "All" doesn't work for links
, just needs to be modified to have ajax enabled on the view. I think what would be good is to merge that one first, then modify the test in it after it's merged. So I'll just put this into NR for now and then we can edit the test once 3555036 is merged.
Comment #6
mdranove commentedComment #7
mdranove commentedComment #8
mdranove commentedComment #9
smustgrave commentedshould have the test attached to the fix
Comment #10
smustgrave commentedActually may be fixed by #3542106: Pager links doesn't work when ajax is enabled
Comment #11
mdranove commentedIt's not fixed by #3542106: Pager links doesn't work when ajax is enabled. I added the test here as requested, but let's just be aware this will cause a merge conflict with 3075674 since they both are going to rely on this test.
Comment #12
mdranove commentedComment #13
mdranove commentedComment #14
mdranove commentedOk so it looks like the changes in https://www.drupal.org/project/better_exposed_filters/issues/3528584 were what caused this issue.
I have it working in the latest MR by reverting those changes, fixing up the ajax js a little bit. Also added a test.
Not sure what the implications are for the issue reported in 3528584.
The "All" button still doesn't work, but this is covered in https://www.drupal.org/project/better_exposed_filters/issues/3075674
I'll put it in NR for now.
Comment #15
smustgrave commentedWe shouldn't just revert that issue but work on a new solution, else we are just adding the problem back
Comment #16
smustgrave commentedAlso I'm not seeing this error. Turned ajax on for one of the bef_test views, turned a filter to use links, everything works
Comment #17
hfernandes commentedThis issue was probably addressed by #3542106: Pager links doesn't work when ajax is enabled.
Comment #18
mdranove commentedThere's still an issue, but it's a different one from the one I originally reported. Updated the repro steps.
Comment #19
mdranove commentedComment #20
mdranove commentedComment #21
dbroll commented+1 for the MR against the latest version, fixed my ajax links not working and subsequent JS error:
Uncaught TypeError: Cannot read properties of undefined (reading 'length') at HTMLAnchorElement. (bef_links_use_ajax.js?t59uzq:25:70) at HTMLAnchorElement.dispatch (jquery.min.js?v=3.7.1:2:40035) at HTMLAnchorElement. (jquery.min.js?v=3.7.1:2:38006)
- Installing drupal/better_exposed_filters (7.1.0-beta4): Extracting archive
- Applying patches for drupal/better_exposed_filters
patches/better_exposed_filters-3555023-203.patch (Issue #3555023: Links ajax broken)
Comment #22
fraserthompsonThe 'name' and 'multiple' attributes were removed for a good reason (because they're not valid on div elements and therefore fail HTML validation), but it looks like this https://git.drupalcode.org/project/better_exposed_filters/-/commit/6cd50... fixes it by returning them as data attributes which makes this MR unnecessary. Maybe the new issue should be opened as a new issue to avoid confusion.
Comment #23
smustgrave commented@mdranoe can you see if #3558648: BEF Links with AJAX and auto-submit doesn't unselect after selecting twice fixes the issue here too? Maybe the tickets can be combined.
Comment #24
mdranove commentedI tested with that MR but still get the same error message
Comment #26
fraserthompson@mdranove try again? I think it was just a simple issue with string lengths when using multiple vs non multiple select.
Comment #27
smustgrave commentedDoesn't work for me, doesn't filter correctly.
Comment #29
smustgrave commentedCombing the two tickets, which means #3558648: BEF Links with AJAX and auto-submit doesn't unselect after selecting twice cannot land with this being fixed and test cases for both.