Problem/Motivation
Currently jwt module version 2.2.* or even 2.* does not support Drupal 11. This is a problem as we want to use the latest Drupal 11 features together with jwt module. There is https://www.drupal.org/project/jwt/issues/3504600 which talks about Drupal 11 support with new features and build a version 3 of the module. Why not simply keep the exact feature set, but just make it compatible with Drupal 11.
Proposed resolution
Make the module compatible with Drupal 11 without adding additional functionality/features.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | jwt-drupal-11-compatibility-3553383.patch | 2.47 KB | lukas.fischer |
Issue fork jwt-3553383
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
lukas.fischer commentedThis needs to be done based on upgrade status report:
Upgrade Status reportContributed projects
JSON Web Token Authentication (JWT) 2.2.1
Check manually
core_version_requirement: ^9.0 || ^10.0is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.core_version_requirement: ^9.0 || ^10.0is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.core_version_requirement: ^9.0 || ^10.0is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.core_version_requirement: ^9.0 || ^10.0is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.core_version_requirement: ^9.0 || ^10.0is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.Comment #3
lukas.fischer commentedPlease find attached a patch. I ran the tests and this were the results:
Comment #4
pwolanin commentedThe CI is not running on Drupal 11.
If we can make that testing happens and it doesn't need any (or minimal) work, then it would be reasonable to add here.
Comment #6
pwolanin commentedThe changes in the MR seem to take out testing Drupal 9 and probably break on Drupal 9.
I am not sure this is possible to do in a way that's going to work on 9, 10, and 11, so we may need instead to push out a 3.x branch sooner
Comment #7
borisson_Drupal 9 hasn't been supported for a while, so dropping support for it, even in a minor, does not seem like a problem to me? See also #3357742: Guidelines for semantic versioning for contributed projects in relation to Drupal core compatibility. Marking this issue as needs review.
Comment #9
pwolanin commentedComment #11
pwolanin commented