Tests are not passing on Drupal 11.4 which is the current "next minor". Other tests are passing.
Issue fork webform-3550117
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
jonathan1055 commentedThe 'phpunit next minor' correctly tries to run just the three tests, but we get no details due to the pre-existing problem
https://git.drupalcode.org/issue/webform-3550117/-/jobs/6764595
Therefore postponing this, as it requires #3547627: LogicException: The hook update_dependencies does not support attributes
Comment #4
jonathan1055 commentedNow that MR742 on #3547627: LogicException: The hook update_dependencies does not support attributes has been merged, this work can be unpostponed. We now see the details of the three failing tests:
Note that I have no knowledge of how webform works, and I am not actively fixing these tests, just preparing this issue so that they can be worked on by someone else.
Comment #5
liam morlandComment #6
jonathan1055 commentedI will rebase/fix conflicts, then see where we are.
Comment #7
jonathan1055 commentedHave you considered adding a weekly scheduled pipeline?
https://git.drupalcode.org/project/webform/-/pipeline_schedules
As it stands, it's not straightforward to see the current state of the pipeline for the repo, you have to look at a MR branch, and then you don't know the effect of the changes in that MR. Having a scheduled pipeline allows new contributors (like me) who are not familiar with the workings of the project to see clearly the current results for the default branch.
Comment #8
liam morlandThanks for the suggestion. I just added a weekly pipeline run.
Comment #9
jonathan1055 commentedAfter a bit of back-and-forth investigation I worked out that only two tests
WebformElementTextFormatTestandWebformSettingsArchivedTestproduce "failures" at 11.4. The log is so long it's surprisingly tedious to find the actual test failures, so here they are, with links to the log.Here is the log for this test
Here's the log.
All (or at least many) of the other "errors" are of the type
InvalidArgumentException: Property summary is unknown.As a bonus, I found that one of the previously skipped tests - WebformStatesRequiredJavaScriptTest now works and passes in all variants - see log. I have no idea how long ago it was marked as skipped, but the comment implies it was back when testing on drupal.org compared to Gitlab CI.
Only the the two failing tests are run here, using the temporary
@group webform_fail_at_next_minor, to reduce log size and speed up run times. So this MR is now ready for whoever wants to work on fixing the those two tests.Comment #14
liam morlandThanks for identifying that the test now passes. I have re-enabled it.
Comment #15
liam morlandThis message doesn't appear to make any sense:
The string "" was not found. What is happening is the string which appears to be empty is actually an HTML tag. So the tag does not display when the text is output on a web page.Comment #16
liam morlandComment #18
idebr commentedTests are now passing on next minor
Relevant change records:
https://www.drupal.org/node/3569941 : Standard profile and recipes no longer use text_with_summary
webform_node no longer installs a body field as the field_type is different in 11.4.x (text_long vs text_with_summary)
https://www.drupal.org/node/3567879 : The long format 'filter tips' are deprecated
Assertions regarding the link 'About text formats' now only apply to <= Drupal 11.3
BC break in hal: #3585446: PHP Fatal error: FieldNormalizer::normalize must be compatible with ListNormalizer::normalize
Comment #19
liam morlandThanks very much.
If I understand correctly, the changes in
TextFormat.phprelate to something removed in Drupal 11.4. There should be a@todosaying that the code should be removed when versions older than 11.4 are not supported.I would be more comfortable if the
halpatch referred to a file instead of a merge request, which could change.Comment #20
idebr commented@todoto TextFormat to indicate the code can be removed once 11.4.0 is the minimum Core versionhalis now patched with a static patch file instead of the MR diff incomposer (next minor)Comment #26
liam morlandThanks!