Nullable type must be used in the definition of getHandlerWithAccessToken().

Issue fork hubspot_api-3549986

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ts.ag created an issue. See original summary.

ts.ag opened merge request !18

ts.ag opened merge request !19

ts.ag’s picture

ts.ag commented
Status: Active » Needs review

Apologies for the stumbling with the MRs, I hope I got them right: !18 for the 2.x-dev branch and !19 for the 3.x-dev branch.

hubspot/api-client also needs addressing. The latest v3 of the module (3.0.0-beta4) requires ^10 which is 10.3. A separate task will need to be created if there is agreement to switch to the latest ^13 (in which some of these PHP 8.4 deprecations are already fixed), but in the meantime I'll see about putting out a dedicated PR for 10.3.

ts.ag’s picture

ts.ag commented

Opened PR 510 for hubspot/api-client to discuss supporting a fix for v10.3.0.
For patching with Composer use:
https://patch-diff.githubusercontent.com/raw/HubSpot/hubspot-api-php/pull/510.patch

andreasderijcke’s picture

andreasderijcke
Location Antwerpen / Gent
commented

Confirming MR19 as OK.
Haven't tested/applied MR18 on a real project.

  • i-trokhanenko committed 19cf9c83 on 3.x authored by ts.ag 
    Issue #3549986: Fix PHP 8.4 deprecation: explicit nullable type must be...
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented

I've merged MR19 into the 3.x branch and I'm planning to release a new version of the module shortly.

I'll also take a look at MR18, but I think over time we'll likely mark the 2.x branch as unsupported. If anyone still relies on the 2.x version or has suggestions on how we should handle it, please feel free to share your thoughts.

Thanks everyone for the work and testing!